Merge pull request #971 from rubocop-hq/fix-InternalAffairs/MethodNameEqual

Fix InternalAffairs/MethodNameEqual

Author: bquorning

.rubocop_todo.yml

@@ -1,17 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-12-12 15:15:34 +0200 using RuboCop version 0.77.0.
+# on 2020-07-15 15:15:30 UTC using RuboCop version 0.87.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 9
-# Cop supports --auto-correct.
-InternalAffairs/MethodNameEqual:
-  Enabled: false
-
 # Offense count: 1
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
   Max: 106

lib/rubocop/cop/rspec/described_class.rb

@@ -142,7 +142,7 @@ def offensive?(node)
           if style == :described_class
             offensive_described_class?(node)
           else
-            node.send_type? && node.method_name == :described_class
+            node.send_type? && node.method?(:described_class)
           end
         end
 

lib/rubocop/cop/rspec/implicit_subject.rb

@@ -63,7 +63,7 @@ def valid_usage?(node)
           example = node.ancestors.find { |parent| example?(parent) }
           return false if example.nil?
 
-          example.method_name == :its || allowed_by_style?(example)
+          example.method?(:its) || allowed_by_style?(example)
         end
 
         def allowed_by_style?(example)

lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -219,7 +219,7 @@ def to_predicate_method(matcher)
         # rubocop:enable Metrics/MethodLength
 
         def replacement_matcher(node)
-          case [cop_config['Strict'], node.method_name == :to]
+          case [cop_config['Strict'], node.method?(:to)]
           when [true, true]
             'be(true)'
           when [true, false]

lib/rubocop/cop/rspec/receive_never.rb

@@ -20,7 +20,7 @@ class ReceiveNever < Cop
         def_node_search :method_on_stub?, '(send nil? :receive ...)'
 
         def on_send(node)
-          return unless node.method_name == :never && method_on_stub?(node)
+          return unless node.method?(:never) && method_on_stub?(node)
 
           add_offense(node.loc.selector) do |corrector|
             autocorrect(corrector, node)

lib/rubocop/cop/rspec/repeated_example.rb

@@ -41,7 +41,7 @@ def repeated_examples(node)
         def example_signature(example)
           key_parts = [example.metadata, example.implementation]
 
-          if example.definition.method_name == :its
+          if example.definition.method?(:its)
             key_parts << example.definition.arguments
           end
 

lib/rubocop/rspec/top_level_describe.rb

@@ -16,7 +16,7 @@ def on_send(node)
       private
 
       def top_level_describe?(node)
-        return false unless node.method_name == :describe
+        return false unless node.method?(:describe)
 
         top_level_nodes.include?(node)
       end
@@ -44,7 +44,7 @@ def single_top_level_describe?
 
       def describe_statement_children(node)
         node.each_child_node(:send).select do |element|
-          element.method_name == :describe
+          element.method?(:describe)
         end
       end
     end