Merge pull request #829 from nickcampbell18/update-rubocop

Fix documentation rake tasks to support Rubocop 0.75

Author: Darhazer

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* Fix documentation rake task to support Rubocop 0.75. ([@nickcampbell18][])
+
 ## 1.36.0 (2019-09-27)
 
 * Fix `RSpec/DescribedClass`'s error when `described_class` is used as part of a constant. ([@pirj][])
@@ -452,3 +454,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@foton]: https://github.com/foton
 [@nc-holodakg]: https://github.com/nc-holodakg
 [@onumis]: https://github.com/onumis
+[@nickcampbell18]: https://github.com/nickcampbell18

lib/rubocop/cop/rspec/implicit_expect.rb

@@ -82,7 +82,7 @@ def offending_expect(node)
           end
         end
 
-        def is_expected_range(source_map) # rubocop:disable PredicateName
+        def is_expected_range(source_map) # rubocop:disable Naming/PredicateName
           Parser::Source::Range.new(
             source_map.expression.source_buffer,
             source_map.expression.begin_pos,

spec/project/changelog_spec.rb

@@ -39,7 +39,7 @@
       it 'has a valid URL' do
         issues.each do |issue|
           number = issue[:number].gsub(/\D/, '')
-          pattern = %r{^https://github\.com/.+/.+/(?:issues|pull)/#{number}$} # rubocop:disable LineLength
+          pattern = %r{^https://github\.com/.+/.+/(?:issues|pull)/#{number}$} # rubocop:disable Metrics/LineLength
           expect(issue[:url]).to match(pattern)
         end
       end

spec/rubocop/cop/rspec/cop_spec.rb

@@ -21,13 +21,15 @@
 
   let(:fake_cop) do
     stub_const('RuboCop::RSpec', Module.new)
-    # rubocop:disable ClassAndModuleChildren, RSpec/LeakyConstantDeclaration
+    # rubocop:disable Style/ClassAndModuleChildren
+    # rubocop:disable RSpec/LeakyConstantDeclaration
     class RuboCop::RSpec::FakeCop < described_class
       def on_send(node)
         add_offense(node, message: 'I flag everything')
       end
     end
-    # rubocop:enable ClassAndModuleChildren, RSpec/LeakyConstantDeclaration
+    # rubocop:enable Style/ClassAndModuleChildren
+    # rubocop:enable RSpec/LeakyConstantDeclaration
     RuboCop::RSpec::FakeCop
   end
 

tasks/cops_documentation.rake

@@ -138,9 +138,32 @@ task generate_cops_documentation: :yard_for_generate_documentation do
   end
   # rubocop:enable Metrics/MethodLength
 
+  def cop_urls(config, cop)
+    rubocop_version = Gem::Version.new(RuboCop::Version::STRING)
+
+    # Since Rubocop v0.75.0 and above, MessageAnnotator#new changed from:
+    #   def initialize(config, cop_config, options)
+    # to:
+    #   def initialize(config, cop_name, cop_config, options)
+    #
+    # Since this library has a loose Rubocop dependency, we select the
+    # right arguments based on the installed version.
+    #
+    # TODO: When Rubocop < 0.75 is no longer supported, remove the second half
+    # of this condition.
+
+    if rubocop_version >= Gem::Version.new('0.75.0')
+      RuboCop::Cop::MessageAnnotator.new(
+        config, cop.name, config.for_cop(cop), {}
+      ).urls
+    else
+      RuboCop::Cop::MessageAnnotator.new(config, config.for_cop(cop), {}).urls
+    end
+  end
+
   def references(config, cop)
-    cop_config = config.for_cop(cop)
-    urls = RuboCop::Cop::MessageAnnotator.new(config, cop_config, {}).urls
+    urls = cop_urls(config, cop)
+
     return '' if urls.empty?
 
     content = h3('References')