Merge pull request #826 from QQism/fix/stubbed-implicit-subjects

Fix implicit subjects mocked/stubbed not detected

Author: Darhazer

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 * Fix documentation rake task to support Rubocop 0.75. ([@nickcampbell18][])
+* Fix `RSpec/SubjectStub` to detect implicit subjects stubbed. ([@QQism][])
 
 ## 1.36.0 (2019-09-27)
 
@@ -455,3 +456,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@nc-holodakg]: https://github.com/nc-holodakg
 [@onumis]: https://github.com/onumis
 [@nickcampbell18]: https://github.com/nickcampbell18
+[@QQism]: https://github.com/QQism

lib/rubocop/cop/rspec/subject_stub.rb

@@ -132,7 +132,10 @@ def redefines_subject?(node)
         # @yieldparam subject_name [Symbol] name of subject being defined
         # @yieldparam parent [RuboCop::Node] parent of subject definition
         def find_subject(node, parent: nil, &block)
-          subject(node) { |name| yield(name, parent) }
+          # An implicit subject is defined by RSpec when no subject is declared
+          subject_name = subject(node) || :subject
+
+          yield(subject_name, parent) if parent
 
           node.each_child_node do |child|
             find_subject(child, parent: node, &block)

spec/rubocop/cop/rspec/subject_stub_spec.rb

@@ -290,4 +290,15 @@
       end
     RUBY
   end
+
+  it 'flags when an implicit subject is mocked' do
+    expect_offense(<<-RUBY)
+      describe Foo do
+        it 'uses an implicit subject' do
+          expect(subject).to receive(:bar).and_return(baz)
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not stub methods of the object under test.
+        end
+      end
+    RUBY
+  end
 end