Fix pending cop when skip is a string

fixes #840

Author: pirj

CHANGELOG.md

@@ -5,6 +5,7 @@
 * Implement `RSpec/DescribedClassModuleWrapping` to disallow RSpec statements within a module. ([@kellysutton][])
 * Fix documentation rake task to support Rubocop 0.75. ([@nickcampbell18][])
 * Fix `RSpec/SubjectStub` to detect implicit subjects stubbed. ([@QQism][])
+* Fix `RSpec/Pending` not flagging `skip` with string values. ([@pirj][])
 
 ## 1.36.0 (2019-09-27)
 

lib/rubocop/cop/rspec/pending.rb

@@ -42,7 +42,7 @@ class Pending < Cop
         def_node_matcher :skipped_in_metadata?, <<-PATTERN
           {
             (send _ _ <#skip_or_pending? ...>)
-            (send _ _ ... (hash <(pair #skip_or_pending? true) ...>))
+            (send _ _ ... (hash <(pair #skip_or_pending? { true str }) ...>))
           }
         PATTERN
 

spec/rubocop/cop/rspec/pending_spec.rb

@@ -108,6 +108,14 @@
     RUBY
   end
 
+  it 'flags blocks with skip: string metadata' do
+    expect_offense(<<-RUBY)
+      it 'test', skip: 'skipped because of being slow' do
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Pending spec found.
+      end
+    RUBY
+  end
+
   it 'flags pending blocks' do
     expect_offense(<<-RUBY)
       pending 'test' do