Fix infinite loop when expected value is literal

Fixes #1092

Author: Darhazer

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* Fixed infinite loop in `RSpec/ExpectActual` autocorrection when both expected and actual values are literals. ([@Darhazer][])
+
 ## 2.0.0 (2020-11-06)
 
 * Remove deprecated class `::RuboCop::Cop::RSpec::Cop`. ([@bquorning][])

lib/rubocop/cop/rspec/expect_actual.rb

@@ -60,6 +60,7 @@ def on_send(node)
           expect_literal(node) do |actual, matcher, expected|
             add_offense(actual.source_range) do |corrector|
               next unless SUPPORTED_MATCHERS.include?(matcher)
+              next if literal?(expected)
 
               swap(corrector, actual, expected)
             end

spec/rubocop/cop/rspec/expect_actual_spec.rb

@@ -304,6 +304,19 @@
     expect_no_corrections
   end
 
+  it 'flags but does not autocorrect when the actual value is also a literal' do
+    expect_offense(<<-RUBY)
+      describe Foo do
+        it 'uses expect incorrectly' do
+          expect([1,2,3]).to eq([1, 2, 3])
+                 ^^^^^^^ Provide the actual you are testing to `expect(...)`.
+        end
+      end
+    RUBY
+
+    expect_no_corrections
+  end
+
   context 'when inspecting rspec-rails routing specs' do
     let(:cop_config) { {} }