Merge pull request #1267 from ydah/drop_ruby_25

Drop Ruby 2.5 support

Author: bquorning

.github/workflows/main.yml

@@ -23,7 +23,6 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - 2.5
           - 2.6
           - 2.7
           - "3.0"

.rubocop.yml

@@ -6,7 +6,7 @@ require:
 
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
   NewCops: disable
   Exclude:
     - 'vendor/**/*'

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* Drop Ruby 2.5 support. ([@ydah][])
+
 ## 2.10.0 (2022-04-19)
 
 * Fix a false positive for `RSpec/EmptyExampleGroup` when expectations in case statement. ([@ydah][])

lib/rubocop/cop/rspec/expect_output.rb

@@ -24,7 +24,7 @@ def on_gvasgn(node)
           # rubocop:disable InternalAffairs/NodeDestructuring
           variable_name, _rhs = *node
           # rubocop:enable InternalAffairs/NodeDestructuring
-          name = variable_name[1..-1]
+          name = variable_name[1..]
           return unless name.eql?('stdout') || name.eql?('stderr')
 
           add_offense(node.loc.name, message: format(MSG, name: name))

lib/rubocop/cop/rspec/variable_definition.rb

@@ -47,7 +47,7 @@ def on_send(node)
         def correct_variable(variable)
           case variable.type
           when :dsym
-            variable.source[1..-1]
+            variable.source[1..]
           when :sym
             variable.value.to_s.inspect
           else

rubocop-rspec.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
 
   spec.version = RuboCop::RSpec::Version::STRING
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.5.0'
+  spec.required_ruby_version = '>= 2.6.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[