Ignore example groups with pending examples

Found hundreds of offences in real-world-rspec

Author: pirj

CHANGELOG.md

@@ -6,6 +6,7 @@
 * Add `RSpec/RepeatedIncludeExample` cop. ([@biinari][])
 * Fix `RSpec/FilePath` when checking a file with a shared example. ([@pirj][])
 * Fix subject nesting detection in `RSpec/LeadingSubject`. ([@pirj][])
+* Fix false positives in `RSpec/EmptyExampleGroup`. ([@pirj][])
 
 ## 1.43.1 (2020-08-17)
 

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -739,6 +739,11 @@ describe Bacon do
     expect(bacon.chunky?).to be_truthy
   end
 end
+
+# good
+describe Bacon do
+  pending 'will add tests later'
+end
 ----
 
 ==== configuration

lib/rubocop/cop/rspec/empty_example_group.rb

@@ -33,6 +33,11 @@ module RSpec
       #     end
       #   end
       #
+      #   # good
+      #   describe Bacon do
+      #     pending 'will add tests later'
+      #   end
+      #
       # @example configuration
       #
       #   # .rubocop.yml
@@ -83,11 +88,14 @@ class EmptyExampleGroup < Base
         #     it_behaves_like 'an animal'
         #     it_behaves_like('a cat') { let(:food) { 'milk' } }
         #     it_has_root_access
+        #     skip
+        #     it 'will be implemented later'
         #
         #   @param node [RuboCop::AST::Node]
         #   @return [Array<RuboCop::AST::Node>] matching nodes
         def_node_matcher :example_or_group_or_include?, <<~PATTERN
           {
+            #{Examples::ALL.send_pattern}
             #{Examples::ALL.block_pattern}
             #{ExampleGroups::ALL.block_pattern}
             #{Includes::ALL.send_pattern}

spec/rubocop/cop/rspec/empty_example_group_spec.rb

@@ -226,4 +226,36 @@
       RUBY
     end
   end
+
+  it 'ignores example groups with pending examples' do
+    expect_no_offenses(<<~RUBY)
+      describe Foo do
+        it 'will be implemented later'
+      end
+
+      describe Foo do
+        it 'will be implemented later', year: 2030
+      end
+
+      describe Foo do
+        pending
+      end
+
+      describe Foo do
+        pending 'too hard to specify'
+      end
+
+      describe Foo do
+        skip
+      end
+
+      describe Foo do
+        skip 'undefined behaviour'
+      end
+
+      xdescribe Foo
+
+      describe Foo
+    RUBY
+  end
 end