Merge pull request #1295 from ydah/doc_improve_for_change_by_zero

Improved documentation for `RSpec/ChangeByZero`

Author: pirj

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -404,6 +404,8 @@ Prefer negated matchers over `to change.by(0)`.
 # bad
 expect { run }.to change(Foo, :bar).by(0)
 expect { run }.to change { Foo.bar }.by(0)
+
+# bad - compound expectations
 expect { run }
   .to change(Foo, :bar).by(0)
   .and change(Foo, :baz).by(0)
@@ -414,6 +416,9 @@ expect { run }
 # good
 expect { run }.not_to change(Foo, :bar)
 expect { run }.not_to change { Foo.bar }
+
+# good - compound expectations
+define_negated_matcher :not_change, :change
 expect { run }
   .to not_change(Foo, :bar)
   .and not_change(Foo, :baz)

lib/rubocop/cop/rspec/change_by_zero.rb

@@ -9,6 +9,8 @@ module RSpec
       #   # bad
       #   expect { run }.to change(Foo, :bar).by(0)
       #   expect { run }.to change { Foo.bar }.by(0)
+      #
+      #   # bad - compound expectations
       #   expect { run }
       #     .to change(Foo, :bar).by(0)
       #     .and change(Foo, :baz).by(0)
@@ -19,6 +21,9 @@ module RSpec
       #   # good
       #   expect { run }.not_to change(Foo, :bar)
       #   expect { run }.not_to change { Foo.bar }
+      #
+      #   # good - compound expectations
+      #   define_negated_matcher :not_change, :change
       #   expect { run }
       #     .to not_change(Foo, :bar)
       #     .and not_change(Foo, :baz)