Use Node#type? with multiple arguments

Author: bquorning

.rubocop_todo.yml

@@ -6,15 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# This cop supports safe autocorrection (--autocorrect).
-InternalAffairs/NodeTypeMultiplePredicates:
-  Exclude:
-    - 'lib/rubocop/cop/rspec/empty_example_group.rb'
-    - 'lib/rubocop/cop/rspec/predicate_matcher.rb'
-    - 'lib/rubocop/cop/rspec/receive_messages.rb'
-    - 'lib/rubocop/cop/rspec/variable_definition.rb'
-    - 'lib/rubocop/cop/rspec/variable_name.rb'
-
 Rake/MethodDefinitionInTask:
   Exclude:
     - 'tasks/cut_release.rake'

lib/rubocop/cop/rspec/empty_example_group.rb

@@ -155,15 +155,15 @@ def offensive?(body)
           return true unless body
           return false if conditionals_with_examples?(body)
 
-          if body.if_type? || body.case_type?
+          if body.type?(:if, :case)
             !examples_in_branches?(body)
           else
             !examples?(body)
           end
         end
 
         def conditionals_with_examples?(body)
-          return false unless body.begin_type? || body.case_type?
+          return false unless body.type?(:begin, :case)
 
           body.each_descendant(:if, :case).any? do |condition_node|
             examples_in_branches?(condition_node)
@@ -172,7 +172,7 @@ def conditionals_with_examples?(body)
 
         def examples_in_branches?(condition_node)
           return false unless condition_node
-          return false if !condition_node.if_type? && !condition_node.case_type?
+          return false unless condition_node.type?(:if, :case)
 
           condition_node.branches.any? { |branch| examples?(branch) }
         end

lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -182,7 +182,7 @@ def uncorrectable_matcher?(node, matcher)
 
         def heredoc_argument?(matcher)
           matcher.arguments.select do |arg|
-            arg.str_type? || arg.dstr_type? || arg.xstr_type?
+            arg.type?(:str, :dstr, :xstr)
           end.any?(&:heredoc?)
         end
 

lib/rubocop/cop/rspec/receive_messages.rb

@@ -148,8 +148,7 @@ def item_range_by_whole_lines(item)
         end
 
         def heredoc_or_splat?(node)
-          ((node.str_type? || node.dstr_type?) && node.heredoc?) ||
-            node.splat_type?
+          (node.type?(:str, :dstr) && node.heredoc?) || node.splat_type?
         end
 
         def requires_quotes?(value)

lib/rubocop/cop/rspec/variable_definition.rb

@@ -69,7 +69,7 @@ def string?(node)
         end
 
         def symbol?(node)
-          node.sym_type? || node.dsym_type?
+          node.type?(:sym, :dsym)
         end
       end
     end

lib/rubocop/cop/rspec/variable_name.rb

@@ -50,7 +50,7 @@ def on_send(node)
           return unless inside_example_group?(node)
 
           variable_definition?(node) do |variable|
-            return if variable.dstr_type? || variable.dsym_type?
+            return if variable.type?(:dstr, :dsym)
             return if matches_allowed_pattern?(variable.value)
 
             check_name(node, variable.value, variable.source_range)