Improve branch coverage

Author: bquorning

.simplecov

@@ -2,7 +2,7 @@
 
 SimpleCov.start do
   enable_coverage :branch
-  minimum_coverage line: 100, branch: 96.79
+  minimum_coverage line: 100, branch: 97.43
   add_filter '/spec/'
   add_filter '/vendor/bundle/'
 end

spec/rubocop/cop/rspec/empty_line_after_subject_spec.rb

@@ -19,6 +19,13 @@
     RUBY
   end
 
+  it 'does not register an offense outside of an example group' do
+    expect_no_offenses(<<~RUBY)
+      subject { foo }
+      bar
+    RUBY
+  end
+
   it 'registers an offense for empty line after subject!' do
     expect_offense(<<~RUBY)
       RSpec.describe User do

spec/rubocop/cop/rspec/leaky_constant_declaration_spec.rb

@@ -73,6 +73,13 @@ class SomeModule::AnotherModule::DummyClass
         end
       RUBY
     end
+
+    it 'ignores outside of example/shared group' do
+      expect_no_offenses(<<~RUBY)
+        class DummyClass
+        end
+      RUBY
+    end
   end
 
   describe 'module defined' do
@@ -85,5 +92,12 @@ module DummyModule
         end
       RUBY
     end
+
+    it 'ignores outside of example/shared group' do
+      expect_no_offenses(<<~RUBY)
+        module Dummymodule
+        end
+      RUBY
+    end
   end
 end

spec/rubocop/cop/rspec/return_from_stub_spec.rb

@@ -176,6 +176,21 @@
       RUBY
     end
 
+    it 'registers, but does not try to autocorrect, heredocs' do
+      expect_offense(<<~RUBY)
+        it do
+          allow(Foo).to receive(:bar) do
+                                      ^^ Use `and_return` for static values.
+            <<-TXT
+              You called me
+            TXT
+          end
+        end
+      RUBY
+
+      expect_no_corrections
+    end
+
     it 'does not register an offense for a stub without return value' do
       expect_no_offenses(<<~RUBY)
         it do
@@ -214,6 +229,19 @@ def stub_foo
       RUBY
     end
 
+    it 'registers, but does not try to autocorrect, heredocs' do
+      expect_offense(<<~RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(<<-TXT)
+                                      ^^^^^^^^^^ Use block for static values.
+            You called me
+          TXT
+        end
+      RUBY
+
+      expect_no_corrections
+    end
+
     it 'does not register an offense for dynamic values returned from method' do
       expect_no_offenses(<<~RUBY)
         it do
@@ -283,5 +311,11 @@ def stub_foo
           'me' }
       RUBY
     end
+
+    it 'ignores irrelevant #and_return methods' do
+      expect_no_offenses(<<~RUBY)
+        library.visit.and_return(book)
+      RUBY
+    end
   end
 end