Merge pull request #2066 from rubocop/include-examples

Add new `RSpec/IncludeExamples` cop to prefer `it_behaves_like` over `include_examples`

Author: pirj

.rubocop.yml

@@ -289,3 +289,7 @@ Performance/StringIdentifierArgument: {Enabled: true}
 Performance/StringInclude: {Enabled: true}
 Performance/Sum: {Enabled: true}
 Performance/ZipWithoutBlock: {Enabled: true}
+
+# Enable our own pending cops.
+
+RSpec/IncludeExamples: {Enabled: true}

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Fix false positive in `RSpec/Pending`, where it would mark the default block `it` as an offense. ([@bquorning])
 - Fix issue when `Style/ContextWording` is configured with a Prefix being interpreted as a boolean, like `on`. ([@sakuro])
+- Add new `RSpec/IncludeExamples` cop to enforce using `it_behaves_like` over `include_examples`. ([@dvandersluis])
 
 ## 3.5.0 (2025-02-16)
 

config/default.yml

@@ -532,6 +532,12 @@ RSpec/ImplicitSubject:
   VersionChanged: '2.13'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitSubject
 
+RSpec/IncludeExamples:
+  Description: Checks for usage of `include_examples`.
+  Enabled: pending
+  VersionAdded: "<<next>>"
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IncludeExamples
+
 RSpec/IndexedLet:
   Description: Do not set up test data using indexes (e.g., `item_1`, `item_2`).
   Enabled: true

docs/modules/ROOT/pages/cops.adoc

@@ -50,6 +50,7 @@
 * xref:cops_rspec.adoc#rspecimplicitblockexpectation[RSpec/ImplicitBlockExpectation]
 * xref:cops_rspec.adoc#rspecimplicitexpect[RSpec/ImplicitExpect]
 * xref:cops_rspec.adoc#rspecimplicitsubject[RSpec/ImplicitSubject]
+* xref:cops_rspec.adoc#rspecincludeexamples[RSpec/IncludeExamples]
 * xref:cops_rspec.adoc#rspecindexedlet[RSpec/IndexedLet]
 * xref:cops_rspec.adoc#rspecinstancespy[RSpec/InstanceSpy]
 * xref:cops_rspec.adoc#rspecinstancevariable[RSpec/InstanceVariable]

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -2743,6 +2743,45 @@ it { expect(named_subject).to be_truthy }
 
 * https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitSubject
 
+[#rspecincludeexamples]
+== RSpec/IncludeExamples
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| Always
+| <<next>>
+| -
+|===
+
+Checks for usage of `include_examples`.
+
+`include_examples`, unlike `it_behaves_like`, does not create its
+own context. As such, using `subject`, `let`, `before`/`after`, etc.
+within shared examples included with `include_examples` can have
+unexpected behavior and side effects.
+
+Prefer using `it_behaves_like` instead.
+
+[#examples-rspecincludeexamples]
+=== Examples
+
+[source,ruby]
+----
+# bad
+include_examples 'examples'
+
+# good
+it_behaves_like 'examples'
+----
+
+[#references-rspecincludeexamples]
+=== References
+
+* https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IncludeExamples
+
 [#rspecindexedlet]
 == RSpec/IndexedLet
 

lib/rubocop/cop/rspec/include_examples.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks for usage of `include_examples`.
+      #
+      # `include_examples`, unlike `it_behaves_like`, does not create its
+      # own context. As such, using `subject`, `let`, `before`/`after`, etc.
+      # within shared examples included with `include_examples` can have
+      # unexpected behavior and side effects.
+      #
+      # Prefer using `it_behaves_like` instead.
+      #
+      # @example
+      #   # bad
+      #   include_examples 'examples'
+      #
+      #   # good
+      #   it_behaves_like 'examples'
+      #
+      class IncludeExamples < Base
+        extend AutoCorrector
+
+        MSG = 'Prefer `it_behaves_like` over `include_examples`.'
+
+        RESTRICT_ON_SEND = %i[include_examples].freeze
+
+        def on_send(node)
+          selector = node.loc.selector
+
+          add_offense(selector) do |corrector|
+            corrector.replace(selector, 'it_behaves_like')
+          end
+        end
+      end
+    end
+  end
+end

lib/rubocop/cop/rspec_cops.rb

@@ -48,6 +48,7 @@
 require_relative 'rspec/implicit_block_expectation'
 require_relative 'rspec/implicit_expect'
 require_relative 'rspec/implicit_subject'
+require_relative 'rspec/include_examples'
 require_relative 'rspec/indexed_let'
 require_relative 'rspec/instance_spy'
 require_relative 'rspec/instance_variable'

spec/rubocop/cop/rspec/base_spec.rb

@@ -113,7 +113,7 @@ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
         RUBY
       end
 
-      include_examples 'it detects `describe`'
+      it_behaves_like 'it detects `describe`'
     end
 
     context 'when `epic` is set as an alias to example group' do
@@ -133,7 +133,7 @@ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
         RUBY
       end
 
-      include_examples 'it detects `describe`'
+      it_behaves_like 'it detects `describe`'
     end
   end
 end

spec/rubocop/cop/rspec/empty_line_after_hook_spec.rb

@@ -310,8 +310,8 @@
   end
 
   context 'when AllowConsecutiveOneLiners option has default value `true`' do
-    include_examples 'always require empty line after hook groups'
-    include_examples 'never allows consecutive multiline blocks'
+    it_behaves_like 'always require empty line after hook groups'
+    it_behaves_like 'never allows consecutive multiline blocks'
 
     it 'allows multiple one-liner blocks' do
       expect_offense(<<~RUBY)
@@ -381,8 +381,8 @@
   context 'when AllowConsecutiveOneLiners option `false`' do
     let(:cop_config) { { 'AllowConsecutiveOneLiners' => false } }
 
-    include_examples 'always require empty line after hook groups'
-    include_examples 'never allows consecutive multiline blocks'
+    it_behaves_like 'always require empty line after hook groups'
+    it_behaves_like 'never allows consecutive multiline blocks'
 
     it 'registers an offense for multiple one-liner same hook blocks' do
       expect_offense(<<~RUBY)

spec/rubocop/cop/rspec/hook_argument_spec.rb

@@ -29,10 +29,10 @@
   end
 
   shared_examples 'an example hook' do
-    include_examples 'ignored hooks'
-    include_examples 'detects style', 'before(:each) { foo }', 'each'
-    include_examples 'detects style', 'before(:example) { foo }', 'example'
-    include_examples 'detects style', 'before { foo }', 'implicit'
+    it_behaves_like 'ignored hooks'
+    it_behaves_like 'detects style', 'before(:each) { foo }', 'each'
+    it_behaves_like 'detects style', 'before(:example) { foo }', 'example'
+    it_behaves_like 'detects style', 'before { foo }', 'implicit'
   end
 
   context 'when EnforcedStyle is :implicit' do
@@ -87,7 +87,7 @@
       RUBY
     end
 
-    include_examples 'an example hook'
+    it_behaves_like 'an example hook'
 
     context 'when Ruby 2.7', :ruby27 do
       it 'detects :each for hooks' do
@@ -172,7 +172,7 @@
       RUBY
     end
 
-    include_examples 'an example hook'
+    it_behaves_like 'an example hook'
 
     context 'when Ruby 2.7', :ruby27 do
       it 'does not flag :each for hooks' do
@@ -257,7 +257,7 @@
       RUBY
     end
 
-    include_examples 'an example hook'
+    it_behaves_like 'an example hook'
 
     context 'when Ruby 2.7', :ruby27 do
       it 'does not flag :example for hooks' do