Merge pull request #85 from nzlaura/feat/assert-redirected-to

feat: support correcting assert_redirected_to in RSpec/Rails/MinitestAssertions

Author: ydah

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 - Fix a false positive for `RspecRails/NegationBeValid` when use `to_not`. ([@ydah])
+- Supporting correcting `assest_redirected_to` in `RSpec/Rails/MinitestAssertions`. ([@nzlaura])
 
 ## 2.32.0 (2025-11-12)
 

docs/modules/ROOT/pages/cops_rspecrails.adoc

@@ -365,6 +365,7 @@ refute_empty(b)
 assert_true(a)
 assert_false(a)
 assert_response :ok
+assert_redirected_to '/users'
 
 # good
 expect(b).to eq(a)
@@ -376,6 +377,7 @@ expect(a).not_to be_empty
 expect(a).to be(true)
 expect(a).to be(false)
 expect(response).to have_http_status(:ok)
+expect(response).to redirect_to('/users')
 ----
 
 [#references-rspecrailsminitestassertions]

lib/rubocop/cop/rspec_rails/minitest_assertions.rb

@@ -19,6 +19,7 @@ module RSpecRails
       #   assert_true(a)
       #   assert_false(a)
       #   assert_response :ok
+      #   assert_redirected_to '/users'
       #
       #   # good
       #   expect(b).to eq(a)
@@ -30,6 +31,7 @@ module RSpecRails
       #   expect(a).to be(true)
       #   expect(a).to be(false)
       #   expect(response).to have_http_status(:ok)
+      #   expect(response).to redirect_to('/users')
       #
       class MinitestAssertions < ::RuboCop::Cop::Base
         extend AutoCorrector
@@ -339,6 +341,28 @@ def assertion
           end
         end
 
+        # :nodoc:
+        class RedirectAssertion < BasicAssertion
+          MATCHERS = %i[
+            assert_redirected_to
+          ].freeze
+
+          ASSERT_ACTUAL_NODE = Struct.new(:source).new('response')
+
+          # @!method self.minitest_assertion(node)
+          def_node_matcher 'self.minitest_assertion', <<~PATTERN # rubocop:disable InternalAffairs/NodeMatcherDirective
+            (send nil? {:assert_redirected_to} $_ $_?)
+          PATTERN
+
+          def self.match(expected, failure_message)
+            new(expected, ASSERT_ACTUAL_NODE, failure_message.first)
+          end
+
+          def assertion
+            "redirect_to(#{expected})"
+          end
+        end
+
         MSG = 'Use `%<prefer>s`.'
 
         # TODO: replace with `BasicAssertion.subclasses` in Ruby 3.1+

spec/rubocop/cop/rspec_rails/minitest_assertions_spec.rb

@@ -1033,4 +1033,105 @@
       RUBY
     end
   end
+
+  context 'with redirect assertions' do
+    it 'registers an offense when using `assert_redirected_to` with a path' do
+      expect_offense(<<~RUBY)
+        assert_redirected_to '/users'
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to redirect_to('/users')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to redirect_to('/users')
+      RUBY
+    end
+
+    # rubocop:disable Layout/LineLength
+    it 'registers an offense when using `assert_redirected_to` with parentheses' do
+      # rubocop:enable Layout/LineLength
+      expect_offense(<<~RUBY)
+        assert_redirected_to('/users')
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to redirect_to('/users')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to redirect_to('/users')
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_redirected_to` with ' \
+       'controller and action' do
+      expect_offense(<<~RUBY)
+        assert_redirected_to controller: 'users', action: 'show'
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to redirect_to(controller: 'users', action: 'show')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to redirect_to(controller: 'users', action: 'show')
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_redirected_to` with ' \
+       'failure message' do
+      expect_offense(<<~RUBY)
+        assert_redirected_to '/users', "expected redirect to users"
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(redirect_to('/users'), "expected redirect to users")`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to(redirect_to('/users'), "expected redirect to users")
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_redirected_to` with ' \
+       'multi-line arguments' do
+      expect_offense(<<~RUBY)
+        assert_redirected_to('/users',
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(redirect_to('/users'), "expected redirect to users")`.
+                             "expected redirect to users")
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to(redirect_to('/users'), "expected redirect to users")
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_redirected_to` with ' \
+       'a URL' do
+      expect_offense(<<~RUBY)
+        assert_redirected_to 'http://example.com/users'
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to redirect_to('http://example.com/users')`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to redirect_to('http://example.com/users')
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_redirected_to` with ' \
+       'a named route' do
+      expect_offense(<<~RUBY)
+        assert_redirected_to users_path
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to redirect_to(users_path)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to redirect_to(users_path)
+      RUBY
+    end
+
+    it 'does not register an offense when using ' \
+       '`expect(response).to redirect_to`' do
+      expect_no_offenses(<<~RUBY)
+        expect(response).to redirect_to('/users')
+      RUBY
+    end
+
+    it 'does not register an offense when using ' \
+       '`expect(response).to redirect_to` with controller and action' do
+      expect_no_offenses(<<~RUBY)
+        expect(response).to redirect_to(controller: 'users', action: 'show')
+      RUBY
+    end
+  end
 end