Merge pull request #1722 from drcapulet/alexc-repeated-subject-calls

Add new RSpec/RepeatedSubjectCall cop

Author: bquorning

.rubocop.yml

@@ -181,6 +181,8 @@ RSpec/RedundantPredicateMatcher:
   Enabled: true
 RSpec/RemoveConst:
   Enabled: true
+RSpec/RepeatedSubjectCall:
+  Enabled: true
 RSpec/SkipBlockInsideExample:
   Enabled: true
 RSpec/SortMetadata:

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Support correcting `assert_nil` and `refute_nil` to `RSpec/Rails/MinitestAssertions`. ([@G-Rath])
 - Fix a false positive for `RSpec/ExpectActual` when used with rspec-rails routing matchers. ([@naveg])
+- Add new `RSpec/RepeatedSubjectCall` cop. ([@drcapulet])
 
 ## 2.26.1 (2024-01-05)
 
@@ -848,6 +849,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@deivid-rodriguez]: https://github.com/deivid-rodriguez
 [@dgollahon]: https://github.com/dgollahon
 [@dmitrytsepelev]: https://github.com/dmitrytsepelev
+[@drcapulet]: https://github.com/drcapulet
 [@drowze]: https://github.com/Drowze
 [@dswij]: https://github.com/dswij
 [@dvandersluis]: https://github.com/dvandersluis

config/default.yml

@@ -813,6 +813,12 @@ RSpec/RepeatedIncludeExample:
   VersionAdded: '1.44'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedIncludeExample
 
+RSpec/RepeatedSubjectCall:
+  Description: Checks for repeated calls to subject missing that it is memoized.
+  Enabled: pending
+  VersionAdded: "<<next>>"
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedSubjectCall
+
 RSpec/ReturnFromStub:
   Description: Checks for consistent style of stub's return setting.
   Enabled: true

docs/modules/ROOT/pages/cops.adoc

@@ -87,6 +87,7 @@
 * xref:cops_rspec.adoc#rspecrepeatedexamplegroupbody[RSpec/RepeatedExampleGroupBody]
 * xref:cops_rspec.adoc#rspecrepeatedexamplegroupdescription[RSpec/RepeatedExampleGroupDescription]
 * xref:cops_rspec.adoc#rspecrepeatedincludeexample[RSpec/RepeatedIncludeExample]
+* xref:cops_rspec.adoc#rspecrepeatedsubjectcall[RSpec/RepeatedSubjectCall]
 * xref:cops_rspec.adoc#rspecreturnfromstub[RSpec/ReturnFromStub]
 * xref:cops_rspec.adoc#rspecscatteredlet[RSpec/ScatteredLet]
 * xref:cops_rspec.adoc#rspecscatteredsetup[RSpec/ScatteredSetup]

lib/rubocop/cop/rspec_rails_cops.rb

@@ -113,6 +113,7 @@
 require_relative 'rspec/repeated_example_group_body'
 require_relative 'rspec/repeated_example_group_description'
 require_relative 'rspec/repeated_include_example'
+require_relative 'rspec/repeated_subject_call'
 require_relative 'rspec/return_from_stub'
 require_relative 'rspec/scattered_let'
 require_relative 'rspec/scattered_setup'