Skip to content

Commit cf29839

Browse files
authored
Merge pull request #30 from rubocop/remove-rubocop-rspec-language-node_pattern
Don't require rubocop/rspec/language/node_pattern
2 parents ee36d00 + 95b5392 commit cf29839

File tree

4 files changed

+7
-64
lines changed

4 files changed

+7
-64
lines changed

.rubocop.yml

Lines changed: 6 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,17 @@ RSpec/ExampleLength:
9898
- heredoc
9999
Max: 11
100100

101-
RSpec/FilePath:
102-
Enabled: false
103-
104101
RSpec/DescribeClass:
105102
Exclude:
106103
- spec/project/**/*.rb
107104

108105
RSpec/MultipleExpectations:
109106
Max: 2
110107

108+
RSpec/SpecFilePathFormat:
109+
CustomTransform:
110+
RSpecRails: rspec_rails
111+
111112
Style/FormatStringToken:
112113
Exclude:
113114
- spec/rubocop/**/*.rb
@@ -135,58 +136,5 @@ Style/ReturnNilInPredicateMethodDefinition:
135136
Enabled: true
136137

137138
# Enable pending rubocop-rspec cops.
138-
139-
RSpec/BeEmpty:
140-
Enabled: true
141-
RSpec/BeEq:
142-
Enabled: true
143-
RSpec/BeNil:
144-
Enabled: true
145-
RSpec/ChangeByZero:
146-
Enabled: true
147-
RSpec/ClassCheck:
148-
Enabled: true
149-
RSpec/ContainExactly:
150-
Enabled: true
151-
RSpec/DuplicatedMetadata:
152-
Enabled: true
153-
RSpec/EmptyMetadata:
154-
Enabled: true
155-
RSpec/Eq:
156-
Enabled: true
157-
RSpec/ExcessiveDocstringSpacing:
158-
Enabled: true
159-
RSpec/IdenticalEqualityAssertion:
160-
Enabled: true
161-
RSpec/IndexedLet:
162-
Enabled: true
163-
RSpec/IsExpectedSpecify:
164-
Enabled: true
165-
RSpec/MatchArray:
166-
Enabled: true
167-
RSpec/MetadataStyle:
168-
Enabled: true
169-
RSpec/NoExpectationExample:
170-
Enabled: true
171-
RSpec/PendingWithoutReason:
172-
Enabled: true
173-
RSpec/ReceiveMessages:
174-
Enabled: true
175-
RSpec/RedundantAround:
176-
Enabled: true
177-
RSpec/RedundantPredicateMatcher:
178-
Enabled: true
179-
RSpec/RemoveConst:
180-
Enabled: true
181-
RSpec/RepeatedSubjectCall:
182-
Enabled: true
183-
RSpec/SkipBlockInsideExample:
184-
Enabled: true
185-
RSpec/SortMetadata:
186-
Enabled: true
187-
RSpec/SpecFilePathSuffix:
188-
Enabled: true
189-
RSpec/SubjectDeclaration:
190-
Enabled: true
191-
RSpec/VerifiedDoubleReference:
192-
Enabled: true
139+
#
140+
# No pending cops yet.

Gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,5 @@ gem 'rubocop-rake', '~> 0.6'
1313
gem 'simplecov', '>= 0.19'
1414
gem 'yard'
1515

16-
# TODO: Move to gemspec when RuboCop RSpec v3 is released.
17-
gem 'rubocop-rspec', '~> 2.27'
18-
1916
local_gemfile = 'Gemfile.local'
2017
eval_gemfile(local_gemfile) if File.exist?(local_gemfile)

lib/rubocop-rspec_rails.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
require 'yaml'
55

66
require 'rubocop'
7-
8-
require 'rubocop/rspec/language/node_pattern'
9-
107
require 'rubocop/rspec/language'
118

129
require_relative 'rubocop/rspec_rails/version'

rubocop-rspec_rails.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,5 @@ Gem::Specification.new do |spec|
3535
}
3636

3737
spec.add_runtime_dependency 'rubocop', '~> 1.61'
38+
spec.add_runtime_dependency 'rubocop-rspec', '~> 3', '>= 3.0.1'
3839
end

0 commit comments

Comments
 (0)