feat: support response assertions

Author: nzlaura

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 - Add `RSpecRails/HttpStatusNameConsistency` cop. ([@taketo1113])
+- Support correcting `assert_response` assertion in in `RSpec/Rails/MinitestAssertions`. ([@nzlaura])
 
 ## 2.31.0 (2025-03-10)
 

lib/rubocop/cop/rspec_rails/minitest_assertions.rb

@@ -315,6 +315,26 @@ def assertion
           end
         end
 
+        # :nodoc:
+        class ResponseAssertion < BasicAssertion
+          MATCHERS = %i[
+            assert_response
+          ].freeze
+
+          # @!method self.minitest_assertion(node)
+          def_node_matcher 'self.minitest_assertion', <<~PATTERN # rubocop:disable InternalAffairs/NodeMatcherDirective
+            (send nil? :assert_response $_ $_?)
+          PATTERN
+
+          def self.match(expected, failure_message)
+            new(expected, nil, failure_message.first)
+          end
+
+          def assertion
+            "have_http_status(#{expected.source})"
+          end
+        end
+
         MSG = 'Use `%<prefer>s`.'
 
         # TODO: replace with `BasicAssertion.subclasses` in Ruby 3.1+

spec/rubocop/cop/rspec_rails/minitest_assertions_spec.rb

@@ -947,4 +947,79 @@
       RUBY
     end
   end
+
+  context 'with response assertions' do
+    it 'registers an offense when using `assert_response`' do
+      expect_offense(<<~RUBY)
+        assert_response :ok
+        ^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(:ok)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to have_http_status(:ok)
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_response` with parentheses' do
+      expect_offense(<<~RUBY)
+        assert_response(:ok)
+        ^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(:ok)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to have_http_status(:ok)
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_response` with ' \
+       'failure message' do
+      expect_offense(<<~RUBY)
+        assert_response :ok, "expected OK status"
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(have_http_status(:ok), "expected OK status")`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to(have_http_status(:ok), "expected OK status")
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_response` with ' \
+       'multi-line arguments' do
+      expect_offense(<<~RUBY)
+        assert_response(:ok,
+        ^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(have_http_status(:ok), "expected OK status")`.
+                        "expected OK status")
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to(have_http_status(:ok), "expected OK status")
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_response` with ' \
+       'numeric status' do
+      expect_offense(<<~RUBY)
+        assert_response 200
+        ^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(200)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to have_http_status(200)
+      RUBY
+    end
+
+    it 'does not register an offense when using ' \
+       '`expect(response).to have_http_status`' do
+      expect_no_offenses(<<~RUBY)
+        expect(response).to have_http_status(:ok)
+      RUBY
+    end
+
+    it 'does not register an offense when using ' \
+       '`expect(response).to have_http_status` with numeric status' do
+      expect_no_offenses(<<~RUBY)
+        expect(response).to have_http_status(200)
+      RUBY
+    end
+  end
 end