Skip to content

Commit f66e112

Browse files
deivid-rodriguezeregon
authored andcommitted
Don't use --force flag on Windows
It was originally added by ruby#253, in order to fix CI. However, now CI passes without it so I assume this was fixed by rubyinstaller2. Force actually bypasses dependency constraints so it's actually installing the latest Bundler in a version of Ruby that's incompatible with it.
1 parent a0d0824 commit f66e112

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

bundler.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,8 @@ export async function installBundler(bundlerVersionInput, rubygemsInputSet, lock
137137
}
138138

139139
const gem = path.join(rubyPrefix, 'bin', 'gem')
140-
// Workaround for https://github.com/rubygems/rubygems/issues/5245
141140
// and for https://github.com/oracle/truffleruby/issues/2780
142-
const force = ((platform.startsWith('windows-') && engine === 'ruby' && floatVersion >= 3.1) || (engine === 'truffleruby')) ? ['--force'] : []
141+
const force = engine === 'truffleruby' ? ['--force'] : []
143142

144143
const versionParts = [...bundlerVersion.matchAll(/\d+/g)].length
145144
const bundlerVersionConstraint = versionParts >= 3 ? bundlerVersion : `~> ${bundlerVersion}.0`

dist/index.js

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)