Improved ActorContext construction.

Author: jdantonio

lib/concurrent/actor_context.rb

@@ -15,8 +15,13 @@ def on_shutdown
 
     def self.included(base)
 
-      def base.spawn
-        Concurrent::SimpleActorRef.new(self.new)
+      class << base
+        protected :new
+
+        def spawn(opts = {})
+          args = opts.fetch(:args, [])
+          Concurrent::SimpleActorRef.new(self.new(*args))
+        end
       end
     end
   end

spec/concurrent/actor_context_spec.rb

@@ -10,9 +10,15 @@ module Concurrent
       end
     end
 
+    it 'protects #initialize' do
+      expect {
+        described_class.new
+      }.to raise_error(NoMethodError)
+    end
+
     context 'callbacks' do
 
-      subject { described_class.new }
+      subject { described_class.send(:new) }
 
       specify { subject.should respond_to :on_start }
 

spec/concurrent/actor_ref_shared.rb

@@ -3,6 +3,10 @@
 def shared_actor_test_class
   Class.new do
     include Concurrent::ActorContext
+    attr_reader :argv
+    def initialize(*args)
+      @argv = args
+    end
     def receive(*msg)
       case msg.first
       when :poison

spec/concurrent/simple_actor_ref_spec.rb

@@ -16,6 +16,21 @@ module Concurrent
 
     it_should_behave_like :actor_ref
 
+    context 'construction' do
+
+      it 'supports :args being nil' do
+        subject = shared_actor_test_class.spawn
+        actor = subject.instance_variable_get(:@actor)
+        actor.argv.should be_empty
+      end
+
+      it 'passes all :args option to the constructor' do
+        subject = shared_actor_test_class.spawn(args: [1, 2, 3, 4])
+        actor = subject.instance_variable_get(:@actor)
+        actor.argv.should eq [1, 2, 3, 4]
+      end
+    end
+
     context 'supervision' do
 
       it 'does not start a new thread on construction' do