Addressed bug with growing thread pools.

Author: jdantonio

lib/concurrent/ruby_thread_pool_executor.rb

@@ -122,9 +122,9 @@ def post(*args, &task)
         @queue << [args, task]
         if Time.now.to_f - @gc_interval >= @last_gc_time
           prune_pool
-          grow_pool
           @last_gc_time = Time.now.to_f
         end
+        grow_pool
         true
       end
     end
@@ -216,7 +216,10 @@ def grow_pool # :nodoc:
       else
         additional = 0
       end
-      additional.times{ @pool << create_worker_thread }
+      additional.times do
+        break if @pool.length >= @max_length
+        @pool << create_worker_thread
+      end
       @largest_length = [@largest_length, @pool.length].max
     end
 

spec/concurrent/cached_thread_pool_shared.rb

@@ -131,7 +131,7 @@
 
   context 'worker creation and caching' do
 
-    subject{ described_class.new(idletime: 1, max_threads: 5, gc_interval: 0) }
+    subject{ described_class.new(idletime: 1, max_threads: 5) }
 
     it 'creates new workers when there are none available' do
       subject.length.should eq 0
@@ -151,7 +151,7 @@
 
     it 'never creates more than :max_threads threads' do
       pool = described_class.new(max_threads: 5)
-      100.times{ sleep(0.01); pool << proc{ sleep(1) } }
+      100.times{ pool << proc{ sleep(1) } }
       sleep(0.1)
       pool.length.should eq 5
       pool.kill