Skip to content

Commit 26b08c2

Browse files
committed
Refactored tests for ScheduledTask.
1 parent 3efbe29 commit 26b08c2

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

spec/concurrent/scheduled_task_spec.rb

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def execute_dereferenceable(subject)
147147
it 'passes the block to the new ScheduledTask' do
148148
@expected = false
149149
task = ScheduledTask.execute(0.1){ @expected = true }
150-
sleep(0.2)
150+
task.value(1)
151151
@expected.should be_true
152152
end
153153

@@ -163,7 +163,7 @@ def execute_dereferenceable(subject)
163163

164164
it 'returns false if the task has already been performed' do
165165
task = ScheduledTask.new(0.1){ 42 }.execute
166-
sleep(0.2)
166+
task.value(1)
167167
task.cancel.should be_false
168168
end
169169

@@ -256,21 +256,20 @@ def execute_dereferenceable(subject)
256256

257257
it 'returns false for an observer added once :fulfilled' do
258258
task = ScheduledTask.new(0.1){ 42 }.execute
259-
sleep(0.2)
259+
task.value(1)
260260
task.add_observer(observer).should be_false
261261
end
262262

263263
it 'returns false for an observer added once :rejected' do
264264
task = ScheduledTask.new(0.1){ raise StandardError }.execute
265-
sleep(0.2)
265+
task.value(0.2)
266266
task.add_observer(observer).should be_false
267267
end
268268

269269
it 'notifies all observers on fulfillment' do
270270
task = ScheduledTask.new(0.1){ 42 }.execute
271271
task.add_observer(observer)
272-
sleep(0.2)
273-
task.value.should == 42
272+
task.value(1).should == 42
274273
task.reason.should be_nil
275274
observer.value.should == 42
276275
observer.reason.should be_nil
@@ -279,8 +278,7 @@ def execute_dereferenceable(subject)
279278
it 'notifies all observers on rejection' do
280279
task = ScheduledTask.new(0.1){ raise StandardError }.execute
281280
task.add_observer(observer)
282-
sleep(0.2)
283-
task.value.should be_nil
281+
task.value(1).should be_nil
284282
task.reason.should be_a(StandardError)
285283
observer.value.should be_nil
286284
observer.reason.should be_a(StandardError)
@@ -289,15 +287,15 @@ def execute_dereferenceable(subject)
289287
it 'does not notify an observer added after fulfillment' do
290288
observer.should_not_receive(:update).with(any_args)
291289
task = ScheduledTask.new(0.1){ 42 }.execute
292-
sleep(0.2)
290+
task.value(1)
293291
task.add_observer(observer)
294292
sleep(0.1)
295293
end
296294

297295
it 'does not notify an observer added after rejection' do
298296
observer.should_not_receive(:update).with(any_args)
299297
task = ScheduledTask.new(0.1){ raise StandardError }.execute
300-
sleep(0.2)
298+
task.value(1)
301299
task.add_observer(observer)
302300
sleep(0.1)
303301
end
@@ -307,9 +305,8 @@ def execute_dereferenceable(subject)
307305
task = ScheduledTask.new(0.1){ 42 }.execute
308306
task.cancel
309307
task.add_observer(observer)
310-
sleep(0.2)
308+
task.value(1)
311309
end
312-
313310
end
314311
end
315312
end

0 commit comments

Comments
 (0)