Skip to content

Commit 345bd4b

Browse files
committed
Doc/TODO update
1 parent 495e5e6 commit 345bd4b

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

lib/concurrent/actor.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
module Concurrent
88
# TODO https://github.com/celluloid/celluloid/wiki/Supervision-Groups
99

10+
# TODO doc
11+
# - what happens if I try to supervise using a normal Context?
12+
13+
1014
# {include:file:doc/actor/main.md}
1115
module Actor
1216

lib/concurrent/actor/context.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ def pass
5050
# so if no {AbstractContext#dead_letter_routing} method is overridden in parent-chain the message ends up in
5151
# `Actor.root.dead_letter_routing` agent which will log warning.
5252
# @return [Reference]
53-
# TODO implement as behaviour
5453
def dead_letter_routing
5554
parent.dead_letter_routing
5655
end

lib/concurrent/channel/unbuffered_channel.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def probe_set_size
1212
end
1313

1414
def push(value)
15+
# TODO set_unless_assigned define on IVar as #set_state? or #try_set_state
1516
until @probe_set.take.set_unless_assigned(value, self)
1617
end
1718
end
@@ -31,4 +32,4 @@ def remove_probe(probe)
3132
end
3233

3334
end
34-
end
35+
end

lib/concurrent/configuration.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,5 +156,6 @@ def self.finalize_executor(executor)
156156
self.finalize_executor(self.configuration.global_timer_set)
157157
self.finalize_executor(self.configuration.global_task_pool)
158158
self.finalize_executor(self.configuration.global_operation_pool)
159+
# TODO may break other test suites using concurrent-ruby, terminates before test is run
159160
end
160161
end

spec/concurrent/actor_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ module Concurrent
55
module Actor
66
i_know_it_is_experimental!
77

8+
# FIXME better tests!
9+
810
# class Reference
911
# def backdoor(&block)
1012
# core.send :schedule_execution do

0 commit comments

Comments
 (0)