Safer Async, with benchmarks.

Author: jdantonio

examples/benchmark_async.rb

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-$: << File.expand_path('../../lib', __FILE__)
+#$: << File.expand_path('../../lib', __FILE__)
 
 require 'benchmark'
 require 'benchmark/ips'
@@ -10,48 +10,117 @@
 
 class CelluloidClass
   include Celluloid
-  def foo
-  end
-  def bar(latch)
-    latch.count_down
+  def foo(latch = nil)
+    latch.count_down if latch
   end
 end
 
 class AsyncClass
   include Concurrent::Async
-  def foo
-  end
-  def bar(latch)
-    latch.count_down
+  def foo(latch = nil)
+    latch.count_down if latch
   end
 end
 
 IPS_NUM = 100
 BMBM_NUM = 100_000
 
 Benchmark.ips do |bm|
-  latch = Concurrent::CountDownLatch.new(1)
   celluloid = CelluloidClass.new
   bm.report('celluloid') do
-    IPS_NUM.times { celluloid.async.foo }
-    celluloid.bar(latch)
+    latch = Concurrent::CountDownLatch.new(IPS_NUM)
+    IPS_NUM.times { celluloid.async.foo(latch) }
     latch.wait
   end
 
   async = AsyncClass.new
-  latch = Concurrent::CountDownLatch.new(1)
   bm.report('async') do
-    IPS_NUM.times { async.async.foo }
-    async.bar(latch)
+    latch = Concurrent::CountDownLatch.new(IPS_NUM)
+    IPS_NUM.times { async.async.foo(latch) }
     latch.wait
   end
 
   bm.compare!
 end
 
-#Benchmark.bmbm do |bm|
-  #bm.report('celluloid') do
-  #end
-  #bm.report('async') do
-  #end
-#end
+Benchmark.bmbm do |bm|
+  celluloid = CelluloidClass.new
+  bm.report('celluloid') do
+    latch = Concurrent::CountDownLatch.new(BMBM_NUM)
+    BMBM_NUM.times { celluloid.async.foo(latch) }
+    latch.wait
+  end
+
+  async = AsyncClass.new
+  bm.report('async') do
+    latch = Concurrent::CountDownLatch.new(BMBM_NUM)
+    BMBM_NUM.times { async.async.foo(latch) }
+    latch.wait
+  end
+end
+
+__END__
+
+===========================================================
+Async Benchmarks
+===========================================================
+
+Computer:
+
+* OS X Yosemite
+  - Version 10.10.4
+* MacBook Pro
+  - Retina, 13-inch, Early 2015
+* Processor 3.1 GHz Intel Core i7
+* Memory 16 GB 1867 MHz DDR3
+* Physical Volumes:
+  - Apple SSD SM0512G
+  - 500 GB
+
+===========================================================
+ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]
+===========================================================
+
+Calculating -------------------------------------
+           celluloid    26.000  i/100ms
+               async    47.000  i/100ms
+-------------------------------------------------
+           celluloid    279.912  (± 6.1%) i/s -      1.404k
+               async    478.932  (± 2.1%) i/s -      2.397k
+
+Comparison:
+               async:      478.9 i/s
+           celluloid:      279.9 i/s - 1.71x slower
+
+Rehearsal ---------------------------------------------
+celluloid   4.080000   0.620000   4.700000 (  4.695271)
+async       2.280000   0.100000   2.380000 (  2.345327)
+------------------------------------ total: 7.080000sec
+
+                user     system      total        real
+celluloid   3.910000   0.580000   4.490000 (  4.503884)
+async       2.220000   0.190000   2.410000 (  2.340467)
+
+===========================================================
+jruby 1.7.19 (1.9.3p551) 2015-01-29 20786bd on Java HotSpot(TM) 64-Bit Server VM 1.8.0_45-b14 +jit [darwin-x86_64]
+===========================================================
+
+Calculating -------------------------------------
+           celluloid     2.000  i/100ms
+               async    32.000  i/100ms
+-------------------------------------------------
+           celluloid     72.887  (±26.1%) i/s -    334.000
+               async      1.822k (±31.6%) i/s -      6.368k
+
+Comparison:
+               async:     1821.9 i/s
+           celluloid:       72.9 i/s - 25.00x slower
+
+Rehearsal ---------------------------------------------
+celluloid   8.890000   1.700000  10.590000 (  5.930000)
+async       2.250000   0.150000   2.400000 (  1.283000)
+----------------------------------- total: 12.990000sec
+
+                user     system      total        real
+celluloid   6.310000   1.530000   7.840000 (  5.817000)
+async       1.590000   0.060000   1.650000 (  0.912000)

lib/concurrent/async.rb

@@ -1,6 +1,3 @@
-require 'thread'
-require 'concurrent/configuration'
-require 'concurrent/errors'
 require 'concurrent/ivar'
 require 'concurrent/executor/single_thread_executor'
 
@@ -332,21 +329,16 @@ def method_missing(method, *args, &block)
         super unless @delegate.respond_to?(method)
         Async::validate_argc(@delegate, method, *args)
 
-        self.define_singleton_method(method) do |*method_args|
-          Async::validate_argc(@delegate, method, *method_args)
-          ivar = Concurrent::IVar.new
-          @executor.post(method_args) do |arguments|
-            begin
-              ivar.set(@delegate.send(method, *arguments, &block))
-            rescue => error
-              ivar.fail(error)
-            end
+        ivar = Concurrent::IVar.new
+        @executor.post(args) do |arguments|
+          begin
+            ivar.set(@delegate.send(method, *arguments, &block))
+          rescue => error
+            ivar.fail(error)
           end
-          ivar.wait if @blocking
-          ivar
         end
-
-        self.send(method, *args)
+        ivar.wait if @blocking
+        ivar
       end
     end
     private_constant :AsyncDelegator

spec/concurrent/async_spec.rb

@@ -202,21 +202,6 @@ def many(*args, &block) nil; end
         val = subject.async.with_block{ :foo }
         expect(val.value).to eq :foo
       end
-
-      context '#method_missing' do
-
-        it 'defines the method after the first call' do
-          expect { subject.async.method(:echo) }.to raise_error(NameError)
-          subject.async.echo(:foo)
-          expect { subject.async.method(:echo) }.not_to raise_error
-        end
-
-        it 'does not define the method on name/arity exception' do
-          expect { subject.async.method(:bogus) }.to raise_error(NameError)
-          expect { subject.async.bogus }.to raise_error(NameError)
-          expect { subject.async.method(:bogus) }.to raise_error(NameError)
-        end
-      end
     end
 
     context '#await' do
@@ -275,26 +260,11 @@ def many(*args, &block) nil; end
         val = subject.await.with_block{ :foo }
         expect(val.value).to eq :foo
       end
-
-      context '#method_missing' do
-
-        it 'defines the method after the first call' do
-          expect { subject.await.method(:echo) }.to raise_error(NameError)
-          subject.await.echo(:foo)
-          expect { subject.await.method(:echo) }.not_to raise_error
-        end
-
-        it 'does not define the method on name/arity exception' do
-          expect { subject.await.method(:bogus) }.to raise_error(NameError)
-          expect { subject.await.bogus }.to raise_error(NameError)
-          expect { subject.await.method(:bogus) }.to raise_error(NameError)
-        end
-      end
     end
 
     context 'locking' do
 
-      it 'uses the same mutex for both #async and #await' do
+      it 'uses the same lock for both #async and #await' do
         object = Class.new {
           include Concurrent::Async
           attr_reader :bucket