SafeTaskExecutor is now a Synchronization::Object

Author: jdantonio

lib/concurrent/executor/safe_task_executor.rb

@@ -1,22 +1,20 @@
-require 'thread'
+require 'concurrent/synchronization'
 
 module Concurrent
 
   # A simple utility class that executes a callable and returns and array of three elements:
   # success - indicating if the callable has been executed without errors
   # value - filled by the callable result if it has been executed without errors, nil otherwise
   # reason - the error risen by the callable if it has been executed with errors, nil otherwise
-  class SafeTaskExecutor
+  class SafeTaskExecutor < Synchronization::Object
 
     def initialize(task, opts = {})
-      @task = task
-      @mutex = Mutex.new
-      @exception_class = opts.fetch(:rescue_exception, false) ? Exception : StandardError
+      super(task, opts)
     end
 
     # @return [Array]
     def execute(*args)
-      @mutex.synchronize do
+      synchronize do
         success = false
         value = reason = nil
 
@@ -31,5 +29,12 @@ def execute(*args)
         [success, value, reason]
       end
     end
+
+    protected
+
+    def ns_initialize(task, opts)
+      @task = task
+      @exception_class = opts.fetch(:rescue_exception, false) ? Exception : StandardError
+    end
   end
 end

spec/concurrent/executor/safe_task_executor_spec.rb

@@ -32,9 +32,7 @@ module Concurrent
         end
 
         it 'protectes #execute with a mutex' do
-          mutex = double(:mutex)
-          expect(Mutex).to receive(:new).with(no_args).and_return(mutex)
-          expect(mutex).to receive(:synchronize).with(no_args)
+          expect(subject).to receive(:synchronize).with(no_args)
           subject.execute
         end
       end