Remove auto call to ns_initialize

Author: pitr-ch

ext/com/concurrent_ruby/ext/SynchronizationLibrary.java

@@ -49,11 +49,9 @@ public JavaObject(Ruby runtime, RubyClass metaClass) {
             super(runtime, metaClass);
         }
 
-        @JRubyMethod(rest = true)
-        public IRubyObject initialize(ThreadContext context, IRubyObject[] args, Block block) {
-            synchronized (this) {
-                return callMethod(context, "ns_initialize", args, block);
-            }
+        @JRubyMethod
+        public IRubyObject initialize(ThreadContext context) {
+            return this;
         }
 
         @JRubyMethod(name = "synchronize", visibility = Visibility.PROTECTED)

lib/concurrent/actor/core.rb

@@ -49,7 +49,8 @@ class Core < Synchronization::Object
       #   any logging system
       # @param [Proc] block for class instantiation
       def initialize(opts = {}, &block)
-        super
+        super(&nil)
+        synchronize { ns_initialize(opts, &block) }
       end
 
       # @return [Reference, nil] of parent actor

lib/concurrent/at_exit.rb

@@ -8,6 +8,11 @@ module Concurrent
   class AtExitImplementation < Synchronization::Object
     include Logging
 
+    def initialize(*args)
+      super()
+      synchronize { ns_initialize *args }
+    end
+
     # Add a handler to be run at `Kernel#at_exit`
     # @param [Object] handler_id optionally provide an id, if allready present, handler is replaced
     # @yield the handler

lib/concurrent/atomic/atomic_boolean.rb

@@ -30,7 +30,8 @@ class MutexAtomicBoolean < Synchronization::Object
     #
     #   @param [Boolean] initial the initial value
     def initialize(initial = false)
-      super(initial)
+      super()
+      synchronize { ns_initialize(initial) }
     end
 
     # @!macro [attach] atomic_boolean_method_value_get

lib/concurrent/atomic/atomic_fixnum.rb

@@ -35,7 +35,8 @@ class MutexAtomicFixnum < Synchronization::Object
     #   @param [Fixnum] initial the initial value
     #   @raise [ArgumentError] if the initial value is not a `Fixnum`
     def initialize(initial = 0)
-      super(initial)
+      super()
+      synchronize { ns_initialize(initial) }
     end
 
     # @!macro [attach] atomic_fixnum_method_value_get

lib/concurrent/atomic/copy_on_notify_observer_set.rb

@@ -8,6 +8,11 @@ module Concurrent
   # prevent concurrency issues
   class CopyOnNotifyObserverSet < Synchronization::Object
 
+    def initialize
+      super()
+      synchronize { ns_initialize }
+    end
+
     # Adds an observer to this set. If a block is passed, the observer will be
     # created by this method and no other params should be passed
     #
@@ -24,7 +29,7 @@ def add_observer(observer=nil, func=:update, &block)
 
       if block
         observer = block
-        func = :call
+        func     = :call
       end
 
       synchronize do

lib/concurrent/atomic/copy_on_write_observer_set.rb

@@ -7,6 +7,11 @@ module Concurrent
   # duplicated and replaced with a new one.
   class CopyOnWriteObserverSet < Synchronization::Object
 
+    def initialize
+      super()
+      synchronize { ns_initialize }
+    end
+
     # Adds an observer to this set
     # If a block is passed, the observer will be created by this method and no
     #   other params should be passed

lib/concurrent/atomic/count_down_latch.rb

@@ -24,7 +24,8 @@ def initialize(count = 1)
       unless count.is_a?(Fixnum) && count >= 0
         raise ArgumentError.new('count must be in integer greater than or equal zero')
       end
-      super(count)
+      super()
+      synchronize { ns_initialize count }
     end
 
     # @!macro [attach] count_down_latch_method_wait

lib/concurrent/atomic/cyclic_barrier.rb

@@ -18,7 +18,8 @@ def initialize(parties, &block)
       if !parties.is_a?(Fixnum) || parties < 1
         raise ArgumentError.new('count must be in integer greater than or equal zero')
       end
-      super(parties, &block)
+      super(&nil)
+      synchronize { ns_initialize parties, &block }
     end
 
     # @return [Fixnum] the number of threads needed to pass the barrier

lib/concurrent/atomic/event.rb

@@ -19,6 +19,7 @@ class Event < Synchronization::Object
     # `Event` will block.
     def initialize
       super
+      synchronize { ns_initialize }
     end
 
     # Is the object in the set state?