Merge pull request #946 from ruby-concurrency/travis

Travis is done and never coming back

Author: eregon

.github/CONTRIBUTING.md

@@ -110,7 +110,7 @@ Update the [CHANGELOG](CHANGELOG.md) with a description of what you have changed
 
 #### Check on Your Pull Request
 
-Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI and AppVeyor. Everything should look green, otherwise fix issues (amending your commit).
+Go back to your pull request after a few minutes and see whether it passed muster with GitHub Actions. Everything should look green, otherwise fix issues (amending your commit).
 
 Please note that testing concurrency is hard. Very hard. We have a few tests that occasionally fail due (mostly) to incorrect synchronization within the test itself. If everything passes locally but you see an error on CI, it's possibly you've become victim to one of the tests. Don't worry, the Concurrent Ruby team reviews the tests output of all failed CI runs and will let you know if the failing test is unrelated to your commit.
 

Rakefile

@@ -77,8 +77,7 @@ begin
       options      = %w[ --color
                     --backtrace
                     --order defined
-                    --format documentation
-                    --tag ~notravis ]
+                    --format documentation ]
       t.rspec_opts = [*options].join(' ')
     end
 

spec/concurrent/actor_spec.rb

@@ -148,7 +148,7 @@ def on_message(message)
           end
         end
 
-        it 'terminates with all its children', notravis: true do
+        it 'terminates with all its children' do
           child = subject.ask! :child
           expect(subject.ask!(:terminated?)).to be_falsey
           subject.ask(:terminate!).wait
@@ -313,7 +313,7 @@ def on_message(message)
       end
 
       describe 'pool' do
-        it 'supports asks', notravis: true do
+        it 'supports asks' do
           children = Queue.new
           pool     = Concurrent::Actor::Utils::Pool.spawn! 'pool', 5 do |index|
             worker = Concurrent::Actor::Utils::AdHoc.spawn! name: "worker-#{index}", supervised: true do

spec/concurrent/agent_spec.rb

@@ -927,7 +927,7 @@ def update(time, old_value, new_value)
           expect(count).to eq expected
         end
 
-        it 'blocks forever if restarted with :clear_actions true', notravis: true do
+        it 'blocks forever if restarted with :clear_actions true' do
           pending('the timing is nearly impossible'); fail
           subject = Agent.new(0, error_mode: :fail)
 
@@ -965,7 +965,7 @@ def update(time, old_value, new_value)
           finish.count_down
         end
 
-        it 'returns true when all prior actions have processed', notravis: true do
+        it 'returns true when all prior actions have processed' do
           subject = Agent.new(0)
           subject.send_via(executor) { sleep(1) }
           5.times { subject.send_via(executor) { nil } }
@@ -980,7 +980,7 @@ def update(time, old_value, new_value)
           expect(subject.await_for(5)).to eq true
         end
 
-        it 'returns false if restarted with :clear_actions true', notravis: true do
+        it 'returns false if restarted with :clear_actions true' do
           pending('the timing is nearly impossible'); fail
           subject = Agent.new(0, error_mode: :fail)
 
@@ -1033,7 +1033,7 @@ def update(time, old_value, new_value)
           expect(subject.await_for(5)).to eq true
         end
 
-        it 'raises an error if restarted with :clear_actions true', notravis: true do
+        it 'raises an error if restarted with :clear_actions true' do
           pending('the timing is nearly impossible'); fail
           subject = Agent.new(0, error_mode: :fail)
 
@@ -1083,7 +1083,7 @@ def update(time, old_value, new_value)
           expect(Concurrent.monotonic_time - start).to be > 0.5
         end
 
-        it 'blocks forever when timeout is nil and restarted with :clear_actions true', notravis: true do
+        it 'blocks forever when timeout is nil and restarted with :clear_actions true' do
           pending('the timing is nearly impossible'); fail
           subject = Agent.new(0, error_mode: :fail)
 
@@ -1116,7 +1116,7 @@ def update(time, old_value, new_value)
           expect(subject.wait(5)).to eq true
         end
 
-        it 'returns false when timeout is given and restarted with :clear_actions true', notravis: true do
+        it 'returns false when timeout is given and restarted with :clear_actions true' do
           pending('the timing is nearly impossible'); fail
           subject = Agent.new(0, error_mode: :fail)
 

spec/concurrent/atomic/cyclic_barrier_spec.rb

@@ -56,7 +56,7 @@ module Concurrent
     end
 
     describe 'reset' do
-      it 'should release all waiting threads', notravis: true do
+      it 'should release all waiting threads' do
         start_latch    = CountDownLatch.new(1)
         continue_latch = CountDownLatch.new(1)
 
@@ -120,7 +120,7 @@ module Concurrent
           expect(latch.wait(1)).to be_truthy
         end
 
-        it 'return false if barrier has been reset', notravis: true do
+        it 'return false if barrier has been reset' do
           latch = CountDownLatch.new(1)
 
           t = in_thread { latch.count_down if barrier.wait == false }

spec/concurrent/atomic/event_spec.rb

@@ -169,7 +169,7 @@ def subject.simulate_spurious_wake_up
         expect(latch.wait(0.1)).to be false
       end
 
-      it 'should resist spurious wake ups with timeout', notravis: true do
+      it 'should resist spurious wake ups with timeout' do
         latch = CountDownLatch.new(1)
         t = in_thread{ subject.wait(0.5); latch.count_down }
         t.join(0.1)

spec/concurrent/atomic/reentrant_read_write_lock_spec.rb

@@ -277,7 +277,7 @@ def wait_up_to(secs, &condition)
           end
         end
 
-        it "wakes up waiting readers when the write lock is released", notravis: true do
+        it "wakes up waiting readers when the write lock is released" do
           latch1,latch2 = CountDownLatch.new,CountDownLatch.new
           good = AtomicFixnum.new(0)
           threads = [

spec/concurrent/channel/buffer/base_spec.rb

@@ -2,7 +2,7 @@
 
 module Concurrent::Channel::Buffer
 
-  RSpec.describe Base, edge: true, notravis: true do
+  RSpec.describe Base, edge: true do
 
     subject { described_class.new }
 

spec/concurrent/channel/buffer/buffered_spec.rb

@@ -2,7 +2,7 @@
 
 module Concurrent::Channel::Buffer
 
-  RSpec.describe Buffered, edge: true, notravis: true do
+  RSpec.describe Buffered, edge: true do
 
     let(:capacity) { 10 }
     subject { described_class.new(capacity) }

spec/concurrent/channel/buffer/dropping_spec.rb

@@ -2,7 +2,7 @@
 
 module Concurrent::Channel::Buffer
 
-  RSpec.describe Dropping, edge: true, notravis: true do
+  RSpec.describe Dropping, edge: true do
 
     subject { described_class.new(10) }