Added Mutex and :rescue_exception option to SafeTaskExecutor.

Author: jdantonio

lib/concurrent/executor/safe_task_executor.rb

@@ -1,28 +1,35 @@
+require 'thread'
+
 module Concurrent
 
   # A simple utility class that executes a callable and returns and array of three elements:
   # success - indicating if the callable has been executed without errors
   # value - filled by the callable result if it has been executed without errors, nil otherwise
   # reason - the error risen by the callable if it has been executed with errors, nil otherwise
   class SafeTaskExecutor
-    def initialize(task)
+
+    def initialize(task, opts = {})
       @task = task
+      @mutex = Mutex.new
+      @exception_class = opts.fetch(:rescue_exception, false) ? Exception : StandardError
     end
 
     # @return [Array]
-    def execute
-      success = false
-      value = reason = nil
-
-      begin
-        value = @task.call
-        success = true
-      rescue => ex
-        reason = ex
+    def execute(*args)
+      @mutex.synchronize do
         success = false
-      end
+        value = reason = nil
+
+        begin
+          value = @task.call(*args)
+          success = true
+        rescue @exception_class => ex
+          reason = ex
+          success = false
+        end
 
-      [success, value, reason]
+        [success, value, reason]
+      end
     end
   end
 end

spec/concurrent/executor/safe_task_executor_spec.rb

@@ -26,6 +26,9 @@ module Concurrent
           reason.should be_nil
         end
 
+        it 'passes all arguments to #execute to the task'
+
+        it 'protectes #execute with a mutex'
       end
 
       context 'failing execution' do
@@ -49,9 +52,12 @@ module Concurrent
           reason.message.should eq 'an error'
         end
 
-      end
+        it 'rescues Exception when :rescue_exception is true'
 
-    end
+        it 'rescues StandardError when :rescue_exception is false'
 
+        it 'rescues StandardError by default'
+      end
+    end
   end
 end