Move #post method to different Shortcut module

Author: pitr-ch

doc/future-promise.md

@@ -0,0 +1,12 @@
+# Futures and Promises
+
+New implementation added in version 0.8 differs from previous versions and has little in common. 
+{Future} represents a value which will become {#completed?} in future, it'll contain {#value} if {#success?} or a {#reason} if {#failed?}. It cannot be directly completed, there are implementations of abstract {Promise} class for that, so {Promise}'s only purpose is to complete a given {Future} object. They are always constructed as a Pair even in chaining methods like {#then}, {#rescue}, {#then_delay}, etc. 
+
+There is few {Promise} implementations:
+
+-   OuterPromise - only Promise used by users, can be completed by outer code. Constructed with {Concurrent::Next.promise} helper method.
+-   Immediate - internal implementation of Promise used to represent immediate evaluation of a block. Constructed with {Concurrent::Next.future} helper method.
+-   Delay - internal implementation of Promise used to represent delayed evaluation of a block. Constructed with {Concurrent::Next.delay} helper method.
+-   ConnectedPromise - used internally to support {Future#with_default_executor}
+

lib/concurrent/next.rb

@@ -2,8 +2,9 @@
 
 # TODO Dereferencable
 # TODO document new global pool setting: no overflow, user has to buffer when there is too many tasks
+# TODO behaviour with Interrupt exceptions is undefined, use Signal.trap to avoid issues
 
-# different name just not to collide
+# @note different name just not to collide for now
 module ConcurrentNext
 
   # executors do not allocate the threads immediately so they can be constants
@@ -42,9 +43,17 @@ def executor(which)
         raise TypeError
       end
     end
+
+    module Shortcuts
+      def post(executor = :fast, &job)
+        ConcurrentNext.executor(executor).post &job
+      end
+    end
   end
 
   extend Executors
+  extend Executors::Shortcuts
+  include Executors::Shortcuts
 
   begin
     require 'jruby'
@@ -91,7 +100,7 @@ def synchronize
     end
 
     def wait(timeout)
-      @condition.wait @mutex, timeout
+      synchronize { @condition.wait @mutex, timeout }
     end
 
     def notify
@@ -118,10 +127,6 @@ class SynchronizedObject < RubySynchronizedObject
 
   class Future < SynchronizedObject
     module Shortcuts
-      def post(executor = :fast, &job)
-        ConcurrentNext.executor(executor).post &job
-        self
-      end
 
       # @return [Future]
       def future(executor = :fast, &block)
@@ -203,7 +208,6 @@ def value(timeout = nil)
     def wait(timeout = nil)
       synchronize do
         touch
-        # TODO interruptions ?
         super timeout if incomplete?
         self
       end