Merge pull request #707 from ianks/safe-atomic-boolean-operations

pitr-ch · web-flow · commit b461ffcb0876 · 2018-05-07T19:44:52.000+02:00
Ensure memory barriers when setting/getting atomic boolean
diff --git a/.gitignore b/.gitignore
@@ -25,4 +25,10 @@ tmtags
 .DS_Store
 .githubtoken
 
-spec/examples.txt
+# Rspec created files
+spec/examples.txt
+
+# Compiled files
+lib/concurrent_ruby_ext.jar
+lib/concurrent/extension.so
+lib/concurrent/extension.bundle
diff --git a/ext/concurrent/atomic_boolean.c b/ext/concurrent/atomic_boolean.c
@@ -21,13 +21,12 @@ VALUE method_atomic_boolean_initialize(int argc, VALUE* argv, VALUE self) {
 }
 
 VALUE method_atomic_boolean_value(VALUE self) {
-  return (VALUE) DATA_PTR(self);
+  return(ir_get(self));
 }
 
 VALUE method_atomic_boolean_value_set(VALUE self, VALUE value) {
   VALUE new_value = TRUTHY(value);
-  DATA_PTR(self) = (void *) new_value;
-  return(new_value);
+  return(ir_set(self, new_value));
 }
 
 VALUE method_atomic_boolean_true_question(VALUE self) {

Original file line number	Diff line number	Diff line change
`@@ -21,13 +21,12 @@ VALUE method_atomic_boolean_initialize(int argc, VALUE* argv, VALUE self) {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`VALUE method_atomic_boolean_value(VALUE self) {`
`24`		`- return (VALUE) DATA_PTR(self);`
	`24`	`+ return(ir_get(self));`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`VALUE method_atomic_boolean_value_set(VALUE self, VALUE value) {`
`28`	`28`	`VALUE new_value = TRUTHY(value);`
`29`		`- DATA_PTR(self) = (void *) new_value;`
`30`		`- return(new_value);`
	`29`	`+ return(ir_set(self, new_value));`
`31`	`30`	`}`
`32`	`31`
`33`	`32`	`VALUE method_atomic_boolean_true_question(VALUE self) {`