Merge pull request #276 from ruby-concurrency/synchronization

Synchronization: Remove mistakenly added lines

Author: Petr Chalupa

lib/concurrent/synchronization/abstract_object.rb

@@ -118,78 +118,6 @@ def ns_signal
       def ns_broadcast
         raise NotImplementedError
       end
-
-      # @example
-      # def initialize
-      #   @val = :val # final never changed value
-      #   ensure_ivar_visibility!
-      #   # not it can be shared as Java's immutable objects with final fields
-      # end
-      def ensure_ivar_visibility!
-        raise NotImplementedError
-      end
-
-      def self.attr_volatile *names
-        attr_accessor *names.map { |name| :"volatile_#{name}" }
-      end
-
-      module CasAttributes
-        def list_attr_volatile_cas
-          @attr_volatile_cas_names ||= []
-          # @attr_volatile_cas_names +
-          #     if superclass.respond_to?(:list_attr_volatile_cas)
-          #       superclass.list_attr_volatile_cas
-          #     else
-          #       []
-          #     end
-        end
-
-        def attr_volatile_cas *names
-          names.each do |name|
-            class_eval <<-RUBY
-            def #(name}
-              #{CasAttributes.ivar_name(name)}.get
-            end
-
-            def #(name}=(value)
-              #{CasAttributes.ivar_name(name)}.set value
-            end
-
-            def #(name}_cas(old, value)
-              #{CasAttributes.ivar_name(name)}.compare_and_set old, value
-            end
-
-            RUBY
-
-            define_method name do
-              instance_variable_get CasAttributes.ivar_name(name)
-            end
-
-            define_method "#{name}=" do |value|
-              instance_variable_set CasAttributes.ivar_name(name), value
-              Rubinius.memory_barrier
-            end
-          end
-        end
-
-        def self.ivar_name(name)
-          :"@volatile_cas_#{name}"
-        end
-
-        def self.extended(base)
-          base.include InstanceMethods
-        end
-
-        module InstanceMethods
-          def initialize
-            self.class.list_attr_volatile_cas.each do |name|
-              isntance_variable_set CasAttributes.ivar_name(name), Atomic.new(nil)
-            end
-            ensure_ivar_visibility!
-            super
-          end
-        end
-      end
     end
   end
 end

lib/concurrent/synchronization/java_pure_object.rb

@@ -32,10 +32,6 @@ def ns_signal
           JRuby.reference0(self).notify
           self
         end
-
-        def ensure_ivar_visibility!
-          # relying on undocumented behavior of JRuby, ivar access is volatile
-        end
       end
     end
   end

lib/concurrent/synchronization/monitor_object.rb

@@ -16,10 +16,6 @@ def ns_wait(timeout = nil)
         @__condition__do_not_use_directly.wait timeout
         self
       end
-
-      def ensure_ivar_visibility!
-        # relying on undocumented behavior of CRuby, GVL quire has lock which ensures visibility of ivars
-      end
     end
   end
 end

lib/concurrent/synchronization/mutex_object.rb

@@ -30,10 +30,6 @@ def ns_wait(timeout = nil)
         @__condition__do_not_use_directly.wait @__lock__do_not_use_directly, timeout
         self
       end
-
-      def ensure_ivar_visibility!
-        # relying on undocumented behavior of CRuby, GVL quire has lock which ensures visibility of ivars
-      end
     end
   end
 end

lib/concurrent/synchronization/rbx_object.rb

@@ -42,25 +42,6 @@ def ns_broadcast
           self
         end
       end
-
-      def ensure_ivar_visibility!
-        Rubinius.memory_barrier
-      end
-
-      def self.attr_volatile *names
-        names.each do |name|
-          ivar = :"@volatile_#{name}"
-          define_method name do
-            Rubinius.memory_barrier
-            instance_variable_get ivar
-          end
-
-          define_method "#{name}=" do |value|
-            instance_variable_set ivar, value
-            Rubinius.memory_barrier
-          end
-        end
-      end
     end
   end
 end