Reduce output pollution by warnings

Author: pitr-ch

lib/concurrent/async.rb

@@ -435,7 +435,7 @@ def await
     #
     # @!visibility private
     def init_synchronization
-      return self if @__async_initialized__
+      return self if defined?(@__async_initialized__) && @__async_initialized__
       @__async_initialized__ = true
       @__async_delegator__ = AsyncDelegator.new(self)
       @__await_delegator__ = AwaitDelegator.new(@__async_delegator__)

lib/concurrent/mutable_struct.rb

@@ -212,6 +212,7 @@ def define_struct(name, members, &block)
         synchronize do
           clazz = Synchronization::AbstractStruct.define_struct_class(MutableStruct, Synchronization::LockableObject, name, members, &block)
           members.each_with_index do |member, index|
+            clazz.send :remove_method, member
             clazz.send(:define_method, member) do
               synchronize { @values[index] }
             end

lib/concurrent/settable_struct.rb

@@ -107,6 +107,7 @@ def define_struct(name, members, &block)
         synchronize do
           clazz = Synchronization::AbstractStruct.define_struct_class(SettableStruct, Synchronization::LockableObject, name, members, &block)
           members.each_with_index do |member, index|
+            clazz.send :remove_method, member if clazz.instance_methods.include? member
             clazz.send(:define_method, member) do
               synchronize { @values[index] }
             end

lib/concurrent/synchronization/abstract_struct.rb

@@ -146,7 +146,7 @@ def ns_initialize(*values)
           end
         end
         members.each_with_index do |member, index|
-          clazz.send :remove_method, member if clazz.method_defined? member
+          clazz.send :remove_method, member if clazz.instance_methods.include? member
           clazz.send(:define_method, member) do
             @values[index]
           end

lib/concurrent/timer_task.rb

@@ -281,6 +281,7 @@ def ns_initialize(opts, &task)
       @run_now = opts[:now] || opts[:run_now]
       @executor = Concurrent::SafeTaskExecutor.new(task)
       @running = Concurrent::AtomicBoolean.new(false)
+      @value = nil
 
       self.observers = Collection::CopyOnNotifyObserverSet.new
     end

spec/concurrent/concern/obligation_spec.rb

@@ -4,12 +4,13 @@ module Concern
     RSpec.describe Obligation do
 
       let (:obligation_class) do
-
         Class.new(Synchronization::LockableObject) do
           include Obligation
           public :state=, :compare_and_set_state, :if_state
           attr_writer :value, :reason
-          def ns_initialize
+          def initialize
+            super
+            set_deref_options
             init_obligation
           end
         end
@@ -72,8 +73,7 @@ def ns_initialize
       context 'fulfilled' do
 
         before(:each) do
-          obligation.state = :fulfilled
-          obligation.send(:value=, 42)
+          obligation.send :set_state, true, 42, nil
           allow(obligation).to receive(:event).and_return(event)
         end
 
@@ -150,7 +150,7 @@ def ns_initialize
       context 'rejected' do
 
         before(:each) do
-          obligation.state = :rejected
+          obligation.send :set_state, false, nil, (raise rescue $!)
           allow(obligation).to receive(:event).and_return(event)
         end
 
@@ -190,19 +190,19 @@ def ns_initialize
           it 'should return immediately if timeout is zero' do
             expect(event).not_to receive(:wait)
 
-            expect { obligation.value!(0) }.to raise_error
+            expect { obligation.value!(0) }.to raise_error StandardError
           end
 
           it 'should return immediately if timeout is not set' do
             expect(event).not_to receive(:wait)
 
-            expect { obligation.value! }.to raise_error
+            expect { obligation.value! }.to raise_error StandardError
           end
 
           it 'should return immediately if timeout is not zero' do
             expect(event).not_to receive(:wait)
 
-            expect { obligation.value!(5) }.to raise_error
+            expect { obligation.value!(5) }.to raise_error StandardError
           end
 
         end
@@ -212,19 +212,19 @@ def ns_initialize
           it 'should return immediately if timeout is zero' do
             expect(event).not_to receive(:wait)
 
-            expect { obligation.no_error!(0) }.to raise_error
+            expect { obligation.no_error!(0) }.to raise_error StandardError
           end
 
           it 'should return immediately if timeout is not set' do
             expect(event).not_to receive(:wait)
 
-            expect { obligation.no_error! }.to raise_error
+            expect { obligation.no_error! }.to raise_error StandardError
           end
 
           it 'should return immediately if timeout is not zero' do
             expect(event).not_to receive(:wait)
 
-            expect { obligation.no_error!(5) }.to raise_error
+            expect { obligation.no_error!(5) }.to raise_error StandardError
           end
 
         end

spec/concurrent/timer_task_spec.rb

@@ -8,7 +8,7 @@ module Concurrent
     context :dereferenceable do
 
       def kill_subject
-        @subject.kill if @subject
+        @subject.kill if defined?(@subject) && @subject
       rescue Exception => ex
         # prevent exceptions with mocks in tests
       end