Merge pull request #700 from ruby-concurrency/pitr-ch/ci

Fixing CI

Author: pitr-ch

Gemfile

@@ -6,13 +6,14 @@ gem 'concurrent-ruby-ext', path: '.', platform: :mri
 
 group :development do
   gem 'rake', '~> 11.0'
-  gem 'rake-compiler', '~> 0.9.5'
-  gem 'rake-compiler-dock', '~> 0.4.3'
+  gem 'rake-compiler', '~> 1.0.0'
+  gem 'rake-compiler-dock', '~> 0.6.0'
   gem 'gem-compiler', '~> 0.3.0'
   gem 'benchmark-ips', '~> 2.7'
 
   # documentation
   gem 'countloc', '~> 0.4.0', :platforms => :mri, :require => false
+  # TODO (pitr-ch 04-May-2018): update to remove: [DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
   gem 'yard', '~> 0.8.0', :require => false
   gem 'redcarpet', '~> 3.3', platforms: :mri # understands github markdown
   gem 'md-ruby-eval'

Rakefile

@@ -181,9 +181,7 @@ begin
                 --backtrace
                 --seed 1
                 --format documentation
-                --tag ~unfinished
-                --tag ~notravis
-                --tag ~buggy ]
+                --tag ~notravis ]
 
   RSpec::Core::RakeTask.new(:travis) do |t|
     t.rspec_opts = ['--color', *options].join(' ')

ext/ConcurrentRubyExtService.java

@@ -2,7 +2,6 @@
 
 import org.jruby.Ruby;
 import org.jruby.runtime.load.BasicLibraryService;
-import com.concurrent_ruby.ext.JRubyMapBackendLibrary;
 
 public class ConcurrentRubyExtService implements BasicLibraryService {
     public boolean basicLoad(final Ruby runtime) throws IOException {

lib/concurrent/actor.rb

@@ -35,9 +35,13 @@ def self.current
     end
 
     @root = Concurrent::Promises.delay do
-      Core.new(parent: nil, name: '/', class: Root, initialized: future = Concurrent::Promises.resolvable_future).reference.tap do
-        future.wait!
-      end
+      Core.
+        new(parent:      nil,
+            name:        '/',
+            class:       Root,
+            initialized: future = Concurrent::Promises.resolvable_future).
+        reference.
+        tap { future.wait! }
     end
 
     # A root actor, a default parent of all actors spawned outside an actor

lib/concurrent/actor/behaviour.rb

@@ -49,7 +49,7 @@ module Actor
     # -   {RestartingContext} uses
     #     {include:Actor::Behaviour.restarting_behaviour_definition}
     module Behaviour
-      MESSAGE_PROCESSED = Object.new
+      MESSAGE_PROCESSED = ::Object.new
 
       require 'concurrent/actor/behaviour/abstract'
       require 'concurrent/actor/behaviour/awaits'

lib/concurrent/actor/core.rb

@@ -90,8 +90,9 @@ def remove_child(child)
       # can be called from other alternative Reference implementations
       # @param [Envelope] envelope
       def on_envelope(envelope)
+        log(DEBUG) { "is  #{envelope.future ? 'asked' : 'told'} #{envelope.message.inspect} by #{envelope.sender}" }
         schedule_execution do
-          log(DEBUG) { "was #{envelope.future ? 'asked' : 'told'} #{envelope.message.inspect} by #{envelope.sender}" }
+          log(DEBUG) { "was #{envelope.future ? 'asked' : 'told'} #{envelope.message.inspect} by #{envelope.sender} - processing" }
           process_envelope envelope
         end
         nil

lib/concurrent/agent.rb

@@ -147,7 +147,7 @@ class Agent < Synchronization::LockableObject
     ERROR_MODES = [:continue, :fail].freeze
     private_constant :ERROR_MODES
 
-    AWAIT_FLAG = Object.new
+    AWAIT_FLAG = ::Object.new
     private_constant :AWAIT_FLAG
 
     AWAIT_ACTION = ->(value, latch) { latch.count_down; AWAIT_FLAG }

lib/concurrent/async.rb

@@ -435,7 +435,7 @@ def await
     #
     # @!visibility private
     def init_synchronization
-      return self if @__async_initialized__
+      return self if defined?(@__async_initialized__) && @__async_initialized__
       @__async_initialized__ = true
       @__async_delegator__ = AsyncDelegator.new(self)
       @__await_delegator__ = AwaitDelegator.new(@__async_delegator__)

lib/concurrent/atomic/count_down_latch.rb

@@ -55,7 +55,7 @@ module Concurrent
   # @!macro internal_implementation_note
   CountDownLatchImplementation = case
                                  when Concurrent.on_jruby?
-                                   JavaCountDownLatch
+                                   MutexCountDownLatch
                                  else
                                    MutexCountDownLatch
                                  end

lib/concurrent/atomic/read_write_lock.rb

@@ -193,7 +193,8 @@ def acquire_write_lock
     #
     # @return [Boolean] true if the lock is successfully released
     def release_write_lock
-      c = @Counter.update { |counter| counter-RUNNING_WRITER }
+      return true unless running_writer?
+      c = @Counter.update { |counter| counter - RUNNING_WRITER }
       @ReadLock.broadcast
       @WriteLock.signal if waiting_writers(c) > 0
       true