MVar: full?

Author: chrisseaton

lib/concurrent/mvar.rb

@@ -20,7 +20,7 @@ def take(timeout = nil)
         @full_condition.wait(@mutex, timeout) if empty?
 
         # If we timed out we'll still be empty
-        if not empty?
+        if full?
           value = @value
           @value = EMPTY
           @empty_condition.signal
@@ -36,7 +36,7 @@ def take(timeout = nil)
     def put(value, timeout = nil)
       @mutex.synchronize do
         # Unless the value is empty, wait for empty to be signalled
-        @empty_condition.wait(@mutex, timeout) unless empty?
+        @empty_condition.wait(@mutex, timeout) if full?
 
         # If we timed out we won't be empty
         if empty?
@@ -53,6 +53,10 @@ def empty?
       @value == EMPTY
     end
 
+    def full?
+      not empty?
+    end
+
   end
 
 end

spec/concurrent/mvar_spec.rb

@@ -96,7 +96,7 @@ module Concurrent
 
     end
 
-    context '#empty' do
+    context '#empty?' do
 
       it 'returns true on an empty MVar' do
         m = MVar.new
@@ -110,6 +110,20 @@ module Concurrent
 
     end
 
+    context '#full?' do
+
+      it 'returns false on an empty MVar' do
+        m = MVar.new
+        m.should_not be_full
+      end
+
+      it 'returns true on a full MVar' do
+        m = MVar.new(14)
+        m.should be_full
+      end
+
+    end
+
   end
 
 end