Merge pull request #373 from repinel/fix-mri-warnings

Petr Chalupa · Petr Chalupa · commit faa76aebe12b · 2015-07-20T13:23:57.000+02:00
Fix some MRI 2.2.2 warnings
diff --git a/lib/concurrent/atomic/atomic_fixnum.rb b/lib/concurrent/atomic/atomic_fixnum.rb
@@ -81,7 +81,7 @@ def increment
     #
     #   @return [Fixnum] the current value after decrementation
     def decrement
-      synchronize { ns_set(@value -1) }
+      synchronize { ns_set(@value - 1) }
     end
 
     alias_method :down, :decrement
diff --git a/lib/concurrent/atomic/read_write_lock.rb b/lib/concurrent/atomic/read_write_lock.rb
@@ -192,7 +192,7 @@ def acquire_write_lock
     #
     # @return [Boolean] true if the lock is successfully released
     def release_write_lock
-      c = @Counter.update { |c| c-RUNNING_WRITER }
+      c = @Counter.update { |counter| counter-RUNNING_WRITER }
       @ReadLock.broadcast
       @WriteLock.signal if waiting_writers(c) > 0
       true

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ def increment`
`81`	`81`	`#`
`82`	`82`	`# @return [Fixnum] the current value after decrementation`
`83`	`83`	`def decrement`
`84`		`- synchronize { ns_set(@value -1) }`
	`84`	`+ synchronize { ns_set(@value - 1) }`
`85`	`85`	`end`
`86`	`86`
`87`	`87`	`alias_method :down, :decrement`
Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ def acquire_write_lock`
`192`	`192`	`#`
`193`	`193`	`# @return [Boolean] true if the lock is successfully released`
`194`	`194`	`def release_write_lock`
`195`		`- c = @Counter.update { \|c\| c-RUNNING_WRITER }`
	`195`	`+ c = @Counter.update { \|counter\| counter-RUNNING_WRITER }`
`196`	`196`	`@ReadLock.broadcast`
`197`	`197`	`@WriteLock.signal if waiting_writers(c) > 0`
`198`	`198`	`true`