Skip to content

Commit 7f57053

Browse files
committed
Need to filter out binary data from compact name
https://youtrack.jetbrains.com/issue/RUBY-15960
1 parent dedc61f commit 7f57053

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

lib/ruby-debug-ide/xml_printer.rb

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def print_variable(name, value, kind)
170170
rescue
171171
end
172172
end
173-
value_str = "[Binary Data]" if (value_str.respond_to?('is_binary_data?') && value_str.is_binary_data?)
173+
value_str = handle_binary_data(value_str)
174174
compact_value_str = build_compact_name(value_str, value)
175175
print("<variable name=\"%s\" compactValue=\"%s\" kind=\"%s\" value=\"%s\" type=\"%s\" hasChildren=\"%s\" objectId=\"%#+x\">",
176176
CGI.escapeHTML(name), CGI.escapeHTML(compact_value_str), kind, CGI.escapeHTML(value_str), value.class,
@@ -184,13 +184,13 @@ def build_compact_name(value_str, value)
184184
if value.is_a?(Array)
185185
slice = value[0..10]
186186
compact = slice.inspect
187-
if (value.size != slice.size)
187+
if value.size != slice.size
188188
compact = compact[0..compact.size-2] + ", ...]"
189189
end
190190
end
191191
if value.is_a?(Hash)
192192
slice = value.sort_by { |k,v| k.to_s }[0..5]
193-
compact = slice.map {|kv| "#{kv[0]}: #{kv[1]}"}.join(", ")
193+
compact = slice.map {|kv| "#{kv[0]}: #{handle_binary_data(kv[1])}"}.join(", ")
194194
compact = "{" + compact + (slice.size != value.size ? ", ..." : "") + "}"
195195
end
196196
compact
@@ -343,6 +343,11 @@ def print(*params)
343343
@interface.print(*params)
344344
end
345345

346+
def handle_binary_data(value)
347+
return "[Binary Data]" if (value.respond_to?('is_binary_data?') && value.is_binary_data?)
348+
value
349+
end
350+
346351
instance_methods.each do |m|
347352
if m.to_s.index('print_') == 0
348353
protect m

0 commit comments

Comments
 (0)