Skip to content

Commit 84e93e3

Browse files
committed
#build_compact_name refactored and made private
1 parent 0d1ec96 commit 84e93e3

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

lib/ruby-debug-ide/xml_printer.rb

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -180,23 +180,6 @@ def print_variable(name, value, kind)
180180
print('</variable>')
181181
end
182182

183-
def build_compact_name(value_str, value)
184-
compact = value_str
185-
if value.is_a?(Array)
186-
slice = value[0..10]
187-
compact = slice.inspect
188-
if value.size != slice.size
189-
compact = compact[0..compact.size-2] + ", ...]"
190-
end
191-
end
192-
if value.is_a?(Hash)
193-
slice = value.sort_by { |k, _| k.to_s }[0..5]
194-
compact = slice.map {|kv| "#{kv[0]}: #{handle_binary_data(kv[1])}"}.join(", ")
195-
compact = "{" + compact + (slice.size != value.size ? ", ..." : "") + "}"
196-
end
197-
compact
198-
end
199-
200183
def print_breakpoints(breakpoints)
201184
print_element 'breakpoints' do
202185
breakpoints.sort_by{|b| b.id }.each do |b|
@@ -359,6 +342,27 @@ def current_thread_attr(context)
359342
end
360343
end
361344

345+
def build_compact_name(value_str, value)
346+
return compact_array_str(value) if value.is_a?(Array)
347+
return compact_hash_str(value) if value.is_a?(Hash)
348+
value_str
349+
end
350+
351+
def compact_array_str(value)
352+
slice = value[0..10]
353+
compact = slice.inspect
354+
if value.size != slice.size
355+
compact[0..compact.size-2] + ", ...]"
356+
end
357+
compact
358+
end
359+
360+
def compact_hash_str(value)
361+
slice = value.sort_by { |k, _| k.to_s }[0..5]
362+
compact = slice.map { |kv| "#{kv[0]}: #{handle_binary_data(kv[1])}" }.join(", ")
363+
"{" + compact + (slice.size != value.size ? ", ..." : "") + "}"
364+
end
365+
362366
instance_methods.each do |m|
363367
if m.to_s.index('print_') == 0
364368
protect m

0 commit comments

Comments
 (0)