Skip to content

Commit 56db533

Browse files
authored
Merge pull request #2153 from dblock/danger-token
Updated Danger token
2 parents 6b31f61 + fef7269 commit 56db533

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

.github/workflows/danger.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
2-
name: Danger
2+
name: danger
33
on:
44
pull_request:
5-
ypes: [opened, reopened, edited, synchronize]
5+
types: [opened, reopened, edited, synchronize]
66
jobs:
77
danger:
88
runs-on: ubuntu-20.04
@@ -14,6 +14,8 @@ jobs:
1414
ruby-version: 2.6
1515
bundler-cache: true
1616
- name: Run Danger
17-
run: bundle exec danger
18-
env:
19-
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
17+
run: |
18+
# the token is public, this is ok
19+
TOKEN='b8b19daa0ade737762c'
20+
TOKEN+='f35edcb328642d371ce86'
21+
DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose

README.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
- [All](#all)
2020
- [Rack](#rack)
2121
- [ActiveRecord without Rails](#activerecord-without-rails)
22+
- [Rails 4](#rails-4)
23+
- [Rails 5+](#rails-5)
2224
- [Alongside Sinatra (or other frameworks)](#alongside-sinatra-or-other-frameworks)
2325
- [Rails](#rails)
2426
- [Rails < 5.2](#rails--52)
@@ -317,13 +319,21 @@ Grape will also automatically respond to HEAD and OPTIONS for all GET, and just
317319
If you want to use ActiveRecord within Grape, you will need to make sure that ActiveRecord's connection pool
318320
is handled correctly.
319321

322+
#### Rails 4
323+
320324
The easiest way to achieve that is by using ActiveRecord's `ConnectionManagement` middleware in your
321325
`config.ru` before mounting Grape, e.g.:
322326

323327
```ruby
324328
use ActiveRecord::ConnectionAdapters::ConnectionManagement
329+
```
325330

326-
run Twitter::API
331+
#### Rails 5+
332+
333+
Use [otr-activerecord](https://github.com/jhollinger/otr-activerecord) as follows:
334+
335+
```ruby
336+
use OTR::ActiveRecord::ConnectionManagement
327337
```
328338

329339
### Alongside Sinatra (or other frameworks)

0 commit comments

Comments
 (0)