Merge pull request #1063 from yairgo/pass_headers_to_validation_errors

Adding headers to validation errors

Author: dblock

CHANGELOG.md

@@ -3,6 +3,7 @@ Next Release
 
 #### Features
 
+* [#1062](https://github.com/intridea/grape/issues/1062): Fix: `Grape::Exceptions::ValidationErrors` will include headers set by `header` - [@yairgo](https://github.com/yairgo).
 * [#1039](https://github.com/intridea/grape/pull/1039): Added support for custom parameter types - [@rnubel](https://github.com/rnubel).
 * [#1047](https://github.com/intridea/grape/pull/1047): Adds `given` to DSL::Parameters, allowing for dependent params - [@rnubel](https://github.com/rnubel).
 * [#1064](https://github.com/intridea/grape/pull/1064): Add public `Grape::Exception::ValidationErrors#full_messages` - [@romanlehnert](https://github.com/romanlehnert).

lib/grape/endpoint.rb

@@ -239,7 +239,7 @@ def run(env)
       end
 
       if validation_errors.any?
-        fail Grape::Exceptions::ValidationErrors, errors: validation_errors
+        fail Grape::Exceptions::ValidationErrors, errors: validation_errors, headers: header
       end
 
       run_filters after_validations

lib/grape/exceptions/validation_errors.rb

@@ -13,7 +13,8 @@ def initialize(args = {})
           @errors[validation_error.params] ||= []
           @errors[validation_error.params] << validation_error
         end
-        super message: full_messages.join(', '), status: 400
+
+        super message: full_messages.join(', '), status: 400, headers: args[:headers]
       end
 
       def each

spec/grape/endpoint_spec.rb

@@ -941,4 +941,25 @@ def memoized
       expect(last_response.body).to eq File.read(__FILE__)
     end
   end
+
+  context 'validation errors' do
+    before do
+      subject.before do
+        header['Access-Control-Allow-Origin'] = '*'
+      end
+      subject.params do
+        requires :id, type: String
+      end
+      subject.get do
+        'should not get here'
+      end
+    end
+
+    it 'returns the errors, and passes headers' do
+      get '/'
+      expect(last_response.status).to eq 400
+      expect(last_response.body).to eq 'id is missing'
+      expect(last_response.headers['Access-Control-Allow-Origin']).to eq('*')
+    end
+  end
 end

spec/grape/exceptions/validation_errors_spec.rb

@@ -5,6 +5,22 @@
   let(:validation_message) { 'FooBar is invalid' }
   let(:validation_error) { OpenStruct.new(params: [validation_message]) }
 
+  context 'initialize' do
+    let(:headers) {
+      {
+        'A-Header-Key' => 'A-Header-Value'
+      }
+    }
+
+    subject do
+      described_class.new(errors: [validation_error], headers: headers)
+    end
+
+    it 'should assign headers through base class' do
+      expect(subject.headers).to eq(headers)
+    end
+  end
+
   context 'message' do
     context 'is not repeated' do
       let(:error) do