Skip to content

Commit 915de58

Browse files
committed
Merge pull request #1104 from dm1try/fix_spec_for_rack_152_dependency
fix spec for rack 1.5.2 dependency
2 parents ca8a0b6 + aadb225 commit 915de58

File tree

4 files changed

+22
-2
lines changed

4 files changed

+22
-2
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,4 @@ gemfile:
1818
- Gemfile
1919
- gemfiles/rails_3.gemfile
2020
- gemfiles/rails_4.gemfile
21+
- gemfiles/rack_1.5.2.gemfile

Appraisals

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@ end
55
appraise "rails-4" do
66
gem "rails", "4.1.6"
77
end
8+
9+
appraise "rack-1.5.2" do
10+
gem "rack", "1.5.2"
11+
end

gemfiles/rack_1.5.2.gemfile

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# This file was generated by Appraisal
2+
3+
source 'https://rubygems.org'
4+
5+
gem 'rack', '1.5.2'
6+
7+
group :development, :test do
8+
gem 'rubocop', '~> 0.31.0'
9+
gem 'guard'
10+
gem 'guard-rspec'
11+
gem 'guard-rubocop'
12+
end
13+
14+
gemspec :path => '../'

spec/grape/integration/rack_spec.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@
2020
env = Rack::MockRequest.env_for('/', options)
2121

2222
unless RUBY_PLATFORM == 'java'
23-
major, minor, release = Rack.release.split('.').map(&:to_i)
24-
pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 1 && ((minor == 5 && release >= 3) || (minor >= 6))
23+
major, minor, patch = Rack.release.split('.').map(&:to_i)
24+
patch ||= 0 # rack <= 1.5.2 does not specify patch version
25+
pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 1 && ((minor == 5 && patch >= 3) || (minor >= 6))
2526
end
2627

2728
expect(JSON.parse(app.call(env)[2].body.first)['params_keys']).to match_array('test')

0 commit comments

Comments
 (0)