Make sure to set documentation attribute even for default: false

Author: Alex Vondrak

CHANGELOG.md

@@ -12,6 +12,7 @@
 * [#950](https://github.com/intridea/grape/pull/950): Status method can now accept one of Rack::Utils status code symbols (:ok, :found, :bad_request, etc.) - [@dabrorius](https://github.com/dabrorius).
 * [#952](https://github.com/intridea/grape/pull/952): Status method now raises error when called with invalid status code - [@dabrorius](https://github.com/dabrorius).
 * [#957](https://github.com/intridea/grape/pull/957): Regexp validator now supports `allow_blank`, `nil` value behavior changed - [@calfzhou](https://giihub.com/calfzhou).
+* [#962](https://github.com/intridea/grape/pull/962): The `default` attribute with `false` value is documented now - [@ajvondrak](https://github.com/ajvondrak).
 * Your contribution here.
 
 0.11.0 (2/23/2015)

lib/grape/validations/params_scope.rb

@@ -117,7 +117,7 @@ def validates(attrs, validations)
         doc_attrs[:desc] = desc if desc
 
         default = validations[:default]
-        doc_attrs[:default] = default if default
+        doc_attrs[:default] = default if validations.key?(:default)
 
         values = validations[:values]
         doc_attrs[:values] = values if values

spec/grape/validations/params_scope_spec.rb

@@ -9,6 +9,70 @@ def app
     subject
   end
 
+  context 'setting a default' do
+    let(:documentation) { subject.routes.first.route_params }
+
+    context 'when the default value is truthy' do
+      before do
+        subject.params do
+          optional :int, type: Integer, default: 42
+        end
+        subject.get
+      end
+
+      it 'adds documentation about the default value' do
+        expect(documentation).to have_key('int')
+        expect(documentation['int']).to have_key(:default)
+        expect(documentation['int'][:default]).to eq(42)
+      end
+    end
+
+    context 'when the default value is false' do
+      before do
+        subject.params do
+          optional :bool, type: Virtus::Attribute::Boolean, default: false
+        end
+        subject.get
+      end
+
+      it 'adds documentation about the default value' do
+        expect(documentation).to have_key('bool')
+        expect(documentation['bool']).to have_key(:default)
+        expect(documentation['bool'][:default]).to eq(false)
+      end
+    end
+
+    context 'when the default value is nil' do
+      before do
+        subject.params do
+          optional :object, type: Object, default: nil
+        end
+        subject.get
+      end
+
+      it 'adds documentation about the default value' do
+        expect(documentation).to have_key('object')
+        expect(documentation['object']).to have_key(:default)
+        expect(documentation['object'][:default]).to eq(nil)
+      end
+    end
+  end
+
+  context 'without a default' do
+    before do
+      subject.params do
+        optional :object, type: Object
+      end
+      subject.get
+    end
+
+    it 'does not add documentation for the default value' do
+      documentation = subject.routes.first.route_params
+      expect(documentation).to have_key('object')
+      expect(documentation['object']).not_to have_key(:default)
+    end
+  end
+
   context 'setting description' do
     [:desc, :description].each do |description_type|
       it "allows setting #{description_type}" do