Parameter check error

[Anthony-Zeng]

I define the request parameter rule to be

 params do
  requires :workflow_nodes, type: Array do
    requires :id, type: String
    requires :title, type: String
    optional :is_start, type: Boolean
    requires :steps, type: Array do
      requires :id, type: String
      optional :type, type: String, values: %w[send_messsge assign_user assign_team tag_conversation snooze close add_commit]
      given type: ->(val) { val == 'send_messsge' } do
        requires :message, type: Hash do
          requires :content, type: String
        end
      end
      given type: ->(val) { val == 'assign_user' } do
        requires :assign_user_id, type: String
      end
      given type: ->(val) { val == 'assign_team' } do
        requires :assign_team_id, type: String
      end
      given type: ->(val) { val == 'tag_conversation' } do
        requires :tags, type: Array[String]
      end
      given type: ->(val) { val == 'add_commit' } do
        requires :comment_content, type: String
      end
     end
  end
end

The content of my request is

{
 "workflow_nodes": [
  {
    "id": "eqibmvEzPo8hQOSt",
    "title": "Node 1",
    "is_start": true,
    "steps": [
      {
        "id": "DvdSZaIm1hEd5XO5",
        "type": "send_messsge",
        "message": {
          "content": "打击好",
          "menus": []
        }
      },
      {
        "id": "VY6MIwycBw0b51Ib",
        "type": "add_commit",
        "comment_content": "初来乍到"
      }
    ]
  }
 ]
}

However, the request returns an inspection error message workflow_nodes[0][steps][0][message][content] is missing

[ericproulx]

Hi @Anthony-Zeng , thank you for opening the issue and I do confirm its a bug.

The following test is failing:

describe 'nested arrays given' do
  subject { last_response }

  let(:app) do
    Class.new(described_class) do
      format :json
      params do
        requires :workflow_nodes, type: Array do
          requires :steps, type: Array do
            requires :id, type: String
            optional :type, type: String, values: %w[send_messsge assign_user assign_team tag_conversation snooze close add_commit]
            given type: ->(val) { val == 'send_messsge' } do
              requires :message, type: Hash do
                requires :content, type: String
              end
            end
          end
        end
      end

      post do

      end
    end
  end

  let(:params) do
    {
      "workflow_nodes": [
        {
          "id": "eqibmvEzPo8hQOSt",
          "title": "Node 1",
          "is_start": true,
          "steps": [
            {
              "id": "DvdSZaIm1hEd5XO5",
              "type": "send_messsge",
              "message": {
                "content": "打击好",
                "menus": []
              }
            },
            {
              "id": "VY6MIwycBw0b51Ib",
              "type": "add_commit",
              "comment_content": "初来乍到"
            }
          ]
        }
      ]
    }
  end

  before do
    post '/', Grape::Json.dump(params), 'CONTENT_TYPE' => 'application/json'
  end

  it { is_expected.to be_successful }
end

[dblock]

@Anthony-Zeng maybe you can help narrow this down to a smaller/minimal test payload and open a PR with a (failing) test like the one from @ericproulx? and maybe even a fix?

[mohammednasser-32]

Hello, I created a PR with a fix 🙏