Endpoint not adding inherited helpers to its scope

[giorni]

c6b72d8 breaks helpers inheritance in grape 3.0.0. From what I tested it seems that because helpers are built at initialization, before the call to inherit_settings, it only adds local blocks and modules to its scope. If that call is moved back to lazy_initialize! it works as what I think is expected.

[ericproulx]

👋 Hi, thanks for opening an issue. Would it be possible to provide a spec or just a example ?

[giorni]

# frozen_string_literal: true

describe 'Mounted API Helper Inheritance' do
  let(:child_api) do
    Class.new(Grape::API) do
      get '/test' do
        parent_helper
      end
    end
  end

  let(:parent_api) do
    context = self
    Class.new(Grape::API) do
      helpers do
        def parent_helper
          'parent helper value'
        end
      end

      mount context.child_api
    end
  end

  def app
    parent_api
  end

  it 'inherits helpers from parent API to mounted child API' do
    get '/test'
    expect(last_response.status).to eq(200)
    expect(last_response.body).to eq('parent helper value')
  end
end

Running this in the repo without changes fail with:

     NameError:
       undefined local variable or method 'parent_helper' for #<Grape::Endpoint:0x00000001224326c8>
     # ./spec/grape/api/mounted_helpers_inheritance_spec.rb:7:in 'block (4 levels) in <top (required)>'

If i put the line @helpers = build_helpers inside the lazy_initialize sync block, or inside the endpoint inherit_settings, it works.

[ericproulx]

Feel PR to open a PR, I don't want to still the glory.

[giorni]

Thanks. PR #2628

[schinery]

Just wanted to check... is this the same thing as #2113 and if so is that issue also resolved?

[schinery]

Just wanted to check... is this the same thing as #2113 and if so is that issue also resolved?

Ignore me, realise that other issue was talking about inherited params 🤦🏻‍♂️