From 54b7afea60bed23133d970cf9bad33b74ff8c9c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20L=C3=B6vmo?= Date: Thu, 10 Apr 2025 15:48:16 +0200 Subject: [PATCH 1/2] Remove unused Request::DEFAULT_PARAMS_BUILDER The constant was introduced in 45abe0dd9f18fcc0e1993b1d5a2988135cb216e1 but is never referenced and hasn't been since its inception. --- lib/grape/request.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/grape/request.rb b/lib/grape/request.rb index 06c389b75..997edac7c 100644 --- a/lib/grape/request.rb +++ b/lib/grape/request.rb @@ -2,7 +2,6 @@ module Grape class Request < Rack::Request - DEFAULT_PARAMS_BUILDER = :hash_with_indifferent_access # Based on rack 3 KNOWN_HEADERS # https://github.com/rack/rack/blob/4f15e7b814922af79605be4b02c5b7c3044ba206/lib/rack/headers.rb#L10 From 8b09187a6073bd3a7992af591acec3e4d9899f86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20L=C3=B6vmo?= Date: Fri, 11 Apr 2025 09:23:20 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6b495d2f..e7ef011ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ * [#2550](https://github.com/ruby-grape/grape/pull/2550): Drop ActiveSupport 6.0 - [@ericproulx](https://github.com/ericproulx). * [#2549](https://github.com/ruby-grape/grape/pull/2549): Delegate cookies management to `Grape::Request` - [@ericproulx](https://github.com/ericproulx). * [#2554](https://github.com/ruby-grape/grape/pull/2554): Remove `Grape::Http::Headers` and `Grape::Util::Lazy::Object` - [@ericproulx](https://github.com/ericproulx). +* [#2556](https://github.com/ruby-grape/grape/pull/2556): Remove unused `Grape::Request::DEFAULT_PARAMS_BUILDER` constant - [@eriklovmo](https://github.com/eriklovmo). * Your contribution here. #### Fixes