Fix grape mounted helpers inheritance #2628
Merged
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Contributor
|
Just a changelog entry and this PR is good :) |
|
I have issues with helpers usage inside UPD: Yep, I've tested the branch in our project, success. UPD2: Thank you for your fix. I hope a new release will be soon. |
giorni
force-pushed
the
fix-helper-inheritance
branch
from
c54fa8e to
fa41911
Compare
build_helpers was moved to be called before inherit_settings was called, resulting in parent helpers missing in child endpoints. This moves helpers build to load while initializing.
giorni
force-pushed
the
fix-helper-inheritance
branch
from
fa41911 to
f952271
Compare
Contributor
Author
|
@ericproulx changelog added to 3.1, is it the right place? |
Contributor
|
I’ll probably cut a 3.0.1 releaseOn 21 Nov 2025, at 11:40, Ricardo Giorni ***@***.***> wrote:giorni left a comment (ruby-grape/grape#2628)
@ericproulx changelog added to 3.1, is it the right place?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
Author
|
Just let me know if you want me to update the changelog to have 3.0.1. |
Member
|
This looks perfect, merging. |
It'd be nice. Do you have plans when? |
Contributor
|
@AlexWayfer Just released 3.0.1 |
Thank you! Works just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_helpers was moved to be called before inherit_settings was called, resulting in parent helpers missing in child endpoints. This moves helpers build to load while initializing.