def collected params method on proxy, closes #100

Author: ajjahn

lib/react/component/class_methods.rb

@@ -98,6 +98,11 @@ def collect_other_params_as(name)
         define_method(name) do
           @_all_others ||= self.class.validator.undefined_props(props)
         end
+
+        validator_in_lexial_scope = validator
+        props_wrapper.define_method(name) do
+          @_all_others ||= validator_in_lexial_scope.undefined_props(props)
+        end
       end
 
       def define_state(*states, &block)

spec/react/param_declaration_spec.rb

@@ -2,6 +2,34 @@
 
 if opal?
 describe 'the param macro' do
+  it 'defines collect_other_params_as method on params proxy' do
+    stub_const 'Foo', Class.new(React::Component::Base)
+    Foo.class_eval do
+      collect_other_params_as :foo
+
+      def render
+        div { params.foo[:bar] }
+      end
+    end
+
+    html = React.render_to_static_markup(React.create_element(Foo,  { bar: 'biz' }))
+    expect(html).to eq('<div>biz</div>')
+  end
+
+  it 'still defines deprecated collect_other_params_as method' do
+    stub_const 'Foo', Class.new(React::Component::Base)
+    Foo.class_eval do
+      collect_other_params_as :foo
+
+      def render
+        div { foo[:bar] }
+      end
+    end
+
+    html = React.render_to_static_markup(React.create_element(Foo,  { bar: 'biz' }))
+    expect(html).to eq('<div>biz</div>')
+  end
+
   it 'still defines deprecated param accessor method' do
     stub_const 'Foo', Class.new(React::Component::Base)
     Foo.class_eval do