Fix RuboCop violations

Author: movermeyer

lib/cldr/export/code/numbers.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # module Cldr
 #   module Export
 #     module Code

lib/cldr/export/data/calendars/gregorian.rb

@@ -138,7 +138,7 @@ def pattern(node, type)
           # That probably means this `fields` method should be moved up to the parent as well.
           def fields
             select("dates/fields/field").each_with_object({}) do |node, result|
-              key  = node.attribute("type").value.underscore.gsub(/dayperiod/, "day_period").to_sym
+              key  = node.attribute("type").value.underscore.gsub("dayperiod", "day_period").to_sym
               name = node.xpath("displayName").first
               result[key] = name.content if name
             end

lib/cldr/export/data/context_transforms.rb

@@ -16,7 +16,7 @@ def context_transforms
             usage_type = usage_node.attribute("type").value.underscore.to_sym
             result[usage_type] = usage_node.xpath("contextTransform").each_with_object({}) do |transform_node, result|
               context_type = transform_node.attribute("type").value.underscore.to_sym
-              transform_type = transform_node.content.underscore.gsub(/firstword/, "first_word")
+              transform_type = transform_node.content.underscore.gsub("firstword", "first_word")
               result[context_type] = transform_type
             end
           end

lib/cldr/export/data/plurals/rules.rb

@@ -1,4 +1,4 @@
-# frozen_string_literal: false
+# frozen_string_literal: true
 
 require "rubygems"
 require "nokogiri"
@@ -151,9 +151,9 @@ def initialize(operator = nil, mod = nil, negate = nil, operand = nil, type = ni
           #
           # http://www.unicode.org/reports/tr35/tr35-numbers.html#Language_Plural_Rules
           def to_ruby
-            @ruby ||= begin
-              return nil unless @operator
+            return unless @operator
 
+            @ruby ||= begin
               enclose = false
               fraction = false
               case @type

lib/cldr/export/data/transforms.rb

@@ -8,7 +8,7 @@ class Transforms < Base
         attr_reader :transform_file
 
         def initialize(transform_file)
-          super(nil)  # no locale
+          super(nil) # no locale
           @transform_file = transform_file
           update(transforms: transforms)
         end

lib/cldr/validate_upstream_assumptions.rb

@@ -29,7 +29,7 @@ def validate_aliases_only_in_root_locale
 
       # Aliases need explicit special handling. Once that handling has been added,
       # the element chain covered by the handling gets added to this list.
-      SUPPORTED_ALIAS_ELEMENT_CHAINS = [
+      SUPPORTED_ALIAS_ELEMENT_CHAINS = [ # rubocop:disable Metrics/CollectionLiteralLength
         "/ldml/dates/calendars/calendar[@type=\"gregorian\"]/dayPeriods/dayPeriodContext[@type=\"format\"]/dayPeriodWidth[@type=\"narrow\"]/alias",
         "/ldml/dates/calendars/calendar[@type=\"gregorian\"]/dayPeriods/dayPeriodContext[@type=\"format\"]/dayPeriodWidth[@type=\"wide\"]/alias",
         "/ldml/dates/calendars/calendar[@type=\"gregorian\"]/dayPeriods/dayPeriodContext[@type=\"stand-alone\"]/dayPeriodWidth[@type=\"abbreviated\"]/alias",

lib/core_ext/hash/deep_sort.rb

@@ -80,7 +80,7 @@ def deep_sort_by!(options = {}, &block)
 
     # comparison for hashes is ill-defined. this performs array or string comparison if the normal comparison fails.
     def <=>(other)
-      super(other) || to_a <=> other.to_a || to_s <=> other.to_s
+      super || to_a <=> other.to_a || to_s <=> other.to_s
     end
   end
 end

lib/core_ext/string/underscore.rb

@@ -2,7 +2,7 @@
 
 class String
   def underscore
-    to_s.gsub(/::/, "/")
+    to_s.gsub("::", "/")
       .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
       .gsub(/([a-z\d])([A-Z])/, '\1_\2')
       .tr("-", "_")