Instrument Net::LDAP::Connection#bind

Author: mtodd

lib/net/ldap.rb

@@ -1324,15 +1324,17 @@ def next_msgid
   end
 
   def bind(auth)
-    meth = auth[:method]
-    if [:simple, :anonymous, :anon].include?(meth)
-      bind_simple auth
-    elsif meth == :sasl
-      bind_sasl(auth)
-    elsif meth == :gss_spnego
-      bind_gss_spnego(auth)
-    else
-      raise Net::LDAP::LdapError, "Unsupported auth method (#{meth})"
+    instrument "bind.net_ldap_connection" do |payload|
+      payload[:method] = meth = auth[:method]
+      if [:simple, :anonymous, :anon].include?(meth)
+        bind_simple auth
+      elsif meth == :sasl
+        bind_sasl(auth)
+      elsif meth == :gss_spnego
+        bind_gss_spnego(auth)
+      else
+        raise Net::LDAP::LdapError, "Unsupported auth method (#{meth})"
+      end
     end
   end
 

spec/unit/ldap_spec.rb

@@ -175,6 +175,23 @@
       result.should == read_result
     end
 
+    it "should publish a bind.net_ldap_connection event" do
+      ber = Net::BER::BerIdentifiedArray.new([0, "", ""])
+      ber.ber_identifier = Net::LDAP::PDU::BindResult
+      bind_result = [2, ber]
+      @tcp_socket.should_receive(:read_ber).and_return(bind_result)
+
+      events = @service.subscribe "bind.net_ldap_connection"
+
+      result = subject.bind(method: :anon)
+      result.should be_success
+
+      # a read event
+      payload, result = events.pop
+      payload.should have_key(:result)
+      result.should be_success
+    end
+
     it "should publish a search.net_ldap_connection event" do
       # search data
       search_data_ber = Net::BER::BerIdentifiedArray.new([2, [