Skip to content

Commit 2594ebb

Browse files
author
Jerry Cheung
committed
Merge remote-tracking branch 'origin/master' into connection-write-request
Conflicts: test/common.rb
2 parents 7e3f4e7 + ec909d9 commit 2594ebb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+1672
-1227
lines changed

.autotest

Lines changed: 0 additions & 11 deletions
This file was deleted.

.gitignore

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
spec/ldap.yml
1+
*~
2+
*.swp
23
.rvmrc
3-
*.gemspec
44
pkg/
5-
*.swp
6-
html/
75
doc/
86
publish/
9-
coverage/
10-
coverage.info
11-
.rake_tasks~
127
Gemfile.lock

.rspec

Lines changed: 0 additions & 2 deletions
This file was deleted.

.travis.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,24 @@ language: ruby
22
rvm:
33
- 1.9.3
44
- 2.0.0
5+
- 2.1.2
56
- jruby-19mode
67
- rbx-19mode
8+
# - rbx-2
9+
10+
env:
11+
- INTEGRATION=openldap
12+
13+
install:
14+
- if [ "$INTEGRATION" = "openldap" ]; then ./script/install-openldap; fi
15+
- bundle install
16+
17+
script: bundle exec rake
18+
719
matrix:
820
allow_failures:
921
- rvm: jruby-19mode
10-
script: bundle exec rake spec
22+
fast_finish: true
23+
24+
notifications:
25+
email: false

Hacking.rdoc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ modification to +Contributors.rdoc+ to add yourself.
4040

4141
== Tests
4242

43-
The Net::LDAP team uses RSpec for unit testing; all changes must have rspec
44-
tests for any new or changed features.
43+
The Net::LDAP team uses [Minitest](http://docs.seattlerb.org/minitest/) for unit
44+
testing; all changes must have tests for any new or changed features.
4545

4646
Your changes should have been tested against at least one real LDAP server; the
4747
current tests are not sufficient to find all possible bugs. It's unlikely that
@@ -57,8 +57,6 @@ installed using RubyGems.
5757

5858
* *hoe*
5959
* *hoe-git*
60-
* *metaid*
61-
* *rspec*
6260
* *flexmock*
6361

6462
== Participation

Manifest.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
.autotest
2-
.rspec
31
.travis.yml
42
Contributors.rdoc
53
Gemfile
@@ -9,7 +7,6 @@ License.rdoc
97
Manifest.txt
108
README.rdoc
119
Rakefile
12-
autotest/discover.rb
1310
lib/net-ldap.rb
1411
lib/net/ber.rb
1512
lib/net/ber/ber_parser.rb
@@ -32,7 +29,6 @@ lib/net/ldap/version.rb
3229
lib/net/snmp.rb
3330
net-ldap.gemspec
3431
spec/integration/ssl_ber_spec.rb
35-
spec/spec.opts
3632
spec/spec_helper.rb
3733
spec/unit/ber/ber_spec.rb
3834
spec/unit/ber/core_ext/array_spec.rb

Rakefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ Hoe.spec 'net-ldap' do |spec|
3030

3131
spec.extra_dev_deps << [ "hoe-git", "~> 1" ]
3232
spec.extra_dev_deps << [ "hoe-gemspec", "~> 1" ]
33-
spec.extra_dev_deps << [ "metaid", "~> 1" ]
3433
spec.extra_dev_deps << [ "flexmock", ">= 1.3.0" ]
35-
spec.extra_dev_deps << [ "rspec", "~> 2.0" ]
3634

3735
spec.clean_globs << "coverage"
3836

@@ -70,7 +68,7 @@ namespace :old do
7068
end
7169
end
7270

73-
desc "Run a full set of integration and unit tests"
71+
desc "Run a full set of integration and unit tests"
7472
task :cruise => [:test, :spec]
7573

7674
# vim: syntax=ruby

autotest/discover.rb

Lines changed: 0 additions & 1 deletion
This file was deleted.

lib/net/ber/core_ext.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,35 +28,35 @@ class String
2828

2929
require 'net/ber/core_ext/array'
3030
# :stopdoc:
31-
class Array
31+
class Array
3232
include Net::BER::Extensions::Array
3333
end
3434
# :startdoc:
3535

3636
require 'net/ber/core_ext/bignum'
3737
# :stopdoc:
38-
class Bignum
38+
class Bignum
3939
include Net::BER::Extensions::Bignum
4040
end
4141
# :startdoc:
4242

4343
require 'net/ber/core_ext/fixnum'
4444
# :stopdoc:
45-
class Fixnum
45+
class Fixnum
4646
include Net::BER::Extensions::Fixnum
4747
end
4848
# :startdoc:
4949

5050
require 'net/ber/core_ext/true_class'
5151
# :stopdoc:
52-
class TrueClass
52+
class TrueClass
5353
include Net::BER::Extensions::TrueClass
5454
end
5555
# :startdoc:
5656

5757
require 'net/ber/core_ext/false_class'
5858
# :stopdoc:
59-
class FalseClass
59+
class FalseClass
6060
include Net::BER::Extensions::FalseClass
6161
end
6262
# :startdoc:

lib/net/ber/core_ext/string.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ def to_ber(code = 0x04)
1616
[code].pack('C') + raw_string.length.to_ber_length_encoding + raw_string
1717
end
1818

19-
##
20-
# Converts a string to a BER string but does *not* encode to UTF-8 first.
21-
# This is required for proper representation of binary data for Microsoft
22-
# Active Directory
23-
def to_ber_bin(code = 0x04)
24-
[code].pack('C') + length.to_ber_length_encoding + self
25-
end
19+
##
20+
# Converts a string to a BER string but does *not* encode to UTF-8 first.
21+
# This is required for proper representation of binary data for Microsoft
22+
# Active Directory
23+
def to_ber_bin(code = 0x04)
24+
[code].pack('C') + length.to_ber_length_encoding + self
25+
end
2626

2727
def raw_utf8_encoded
2828
if self.respond_to?(:encode)

0 commit comments

Comments
 (0)