Skip to content

Commit 480bd17

Browse files
committed
Encode true as xFF
According to the spec: http://tools.ietf.org/html/rfc4511#section-5.1
1 parent f40c46e commit 480bd17

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/net/ber/core_ext/true_class.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ module Net::BER::Extensions::TrueClass
55
##
66
# Converts +true+ to the BER wireline representation of +true+.
77
def to_ber
8-
# 20100319 AZ: Note that this may not be the completely correct value,
9-
# per some test documentation. We need to determine the truth of this.
10-
"\001\001\001"
8+
# http://tools.ietf.org/html/rfc4511#section-5.1
9+
"\001\001\xFF"
1110
end
1211
end

test/ber/test_ber.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ def test_array
1212
assert_equal ary, encoded_ary.read_ber
1313
end
1414

15+
# http://tools.ietf.org/html/rfc4511#section-5.1
1516
def test_true
16-
assert_equal "\x01\x01\x01", true.to_ber
17+
assert_equal "\x01\x01\xFF", true.to_ber
1718
end
1819

1920
def test_false

0 commit comments

Comments
 (0)