Skip to content

Commit a808c89

Browse files
author
Rory O'Connell
committed
Merge pull request #59 from satoryu/make_spec_green
Make all specs green
2 parents e2290bb + fe95779 commit a808c89

File tree

5 files changed

+18
-6
lines changed

5 files changed

+18
-6
lines changed

.travis.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
language: ruby
2+
rvm:
3+
- 1.8.7
4+
- 1.9.2
5+
- 1.9.3
6+
- 2.0.0
7+
- jruby-18mode
8+
- jruby-19mode
9+
- rbx-18mode
10+
- rbx-19mode
11+
- ree
12+
script: bundle exec rake spec

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
source :rubygems
1+
source 'https://rubygems.org'
22
gemspec

README.rdoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
= Net::LDAP for Ruby
1+
= Net::LDAP for Ruby {<img src="https://travis-ci.org/ruby-ldap/ruby-net-ldap.png" />}[https://travis-ci.org/ruby-ldap/ruby-net-ldap]
22

33
== Description
44

spec/unit/ber/ber_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@
8989
["6a31b4a12aa27a41aca9603f27dd5116"].pack("H*").to_ber_bin.should ==
9090
"\x04\x10" + "j1\xB4\xA1*\xA2zA\xAC\xA9`?'\xDDQ\x16"
9191
end
92-
it "should fail on strings that can not be converted to UTF-8" do
92+
it "should not fail on strings that can not be converted to UTF-8" do
9393
error = Encoding::UndefinedConversionError
94-
lambda {"\x81".to_ber }.should raise_exception(error)
94+
lambda {"\x81".to_ber }.should_not raise_exception(error)
9595
end
9696
end
9797
end

spec/unit/ldap/search_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
describe Net::LDAP, "search method" do
44
class FakeConnection
55
def search(args)
6-
OpenStruct.new(:result_code => 1, :message => "error")
6+
OpenStruct.new(:result_code => 1, :message => "error", :success? => false)
77
end
88
end
99

@@ -22,7 +22,7 @@ def search(args)
2222
context "when :return_result => false" do
2323
it "should return false upon error" do
2424
result = @connection.search(:return_result => false)
25-
result.result_code.should == 1
25+
result.should be_false
2626
end
2727
end
2828

0 commit comments

Comments
 (0)