add Connection#write_request

higher level abstraction to make testing easier and to DRY up existing
socket IO

Author: Jerry Cheung

lib/net/ldap/connection.rb

@@ -141,6 +141,12 @@ def write(packet)
   end
   private :write
 
+  # Internal: Convert `request` and `controls` to a BER data packet with the
+  # next message id and call `#write` on it.
+  def write_request(request, controls = nil)
+    write([next_msgid, request, controls].compact.to_ber_sequence)
+  end
+
   def next_msgid
     @msgid ||= 0
     @msgid += 1

test/test_ldap_connection.rb

@@ -21,4 +21,27 @@ def test_modify_ops_replace
     expected = [ "0#\n\x01\x020\x1E\x04\x04mail1\x16\x04\x14[email protected]" ]
     assert_equal(expected, result)
   end
+
+  def test_write_request
+    mock = Minitest::Mock.new
+    mock.expect(:write, true, [[1, "request"].to_ber_sequence])
+    conn = Net::LDAP::Connection.new(:socket => mock)
+    conn.write_request("request")
+  end
+
+  def test_write_request_with_controls
+    mock = Minitest::Mock.new
+    mock.expect(:write, true, [[1, "request", "controls"].to_ber_sequence])
+    conn = Net::LDAP::Connection.new(:socket => mock)
+    conn.write_request("request", "controls")
+  end
+
+  def test_write_request_increments_msgid
+    mock = Minitest::Mock.new
+    mock.expect(:write, true, [[1, "request1"].to_ber_sequence])
+    mock.expect(:write, true, [[2, "request2"].to_ber_sequence])
+    conn = Net::LDAP::Connection.new(:socket => mock)
+    conn.write_request("request1")
+    conn.write_request("request2")
+  end
 end