Skip to content

Commit f102f50

Browse files
committed
Do not add controls when it is empty. Fixed #17
Some LDAP servers, such as ApacheDS, consider as invalid protocol, if controls is an empty array.
1 parent 7dd6c3a commit f102f50

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/net/ldap.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,9 +1389,9 @@ def search(args = {})
13891389
false.to_ber,
13901390
rfc2696_cookie.map{ |v| v.to_ber}.to_ber_sequence.to_s.to_ber
13911391
].to_ber_sequence if paged_searches_supported
1392-
controls = controls.to_ber_contextspecific(0)
1392+
controls = controls.empty? ? nil : controls.to_ber_contextspecific(0)
13931393

1394-
pkt = [next_msgid.to_ber, request, controls].to_ber_sequence
1394+
pkt = [next_msgid.to_ber, request, controls].compact.to_ber_sequence
13951395
@conn.write pkt
13961396

13971397
result_code = 0

0 commit comments

Comments
 (0)